Merge lp:~vrruiz/unity-webapps-yahoomail/fix-1188594 into lp:unity-webapps-yahoomail

Proposed by Víctor R. Ruiz
Status: Merged
Merged at revision: 48
Proposed branch: lp:~vrruiz/unity-webapps-yahoomail/fix-1188594
Merge into: lp:unity-webapps-yahoomail
Diff against target: 12 lines (+1/-1)
1 file modified
YahooMail.test.js (+1/-1)
To merge this branch: bzr merge lp:~vrruiz/unity-webapps-yahoomail/fix-1188594
Reviewer Review Type Date Requested Status
Robert Bruce Park (community) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Alexandre Abreu (community) Approve
Review via email: mp+168061@code.launchpad.net

Commit message

Fixes test.

Description of the change

Fixes test.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alexandre Abreu (abreu-alexandre) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Robert Bruce Park (robru) wrote :

Victor, jenkins seems to be indicating a merge conflict here. Can you try merging trunk into this branch and then pushing it again? hopefully that'll make it work.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'YahooMail.test.js'
--- YahooMail.test.js 2013-04-30 20:42:40 +0000
+++ YahooMail.test.js 2013-06-07 13:48:40 +0000
@@ -27,7 +27,7 @@
27 validateCallLog: function (log, out) {27 validateCallLog: function (log, out) {
28 assertEquals('Unity.init', log[0].func, 'Unity.init');28 assertEquals('Unity.init', log[0].func, 'Unity.init');
29 assertEquals('Yahoo Mail', log[0].args[0].name, 'Yahoo Mail');29 assertEquals('Yahoo Mail', log[0].args[0].name, 'Yahoo Mail');
30 assertEquals('Unity.MessagingIndicator.clearIndicators', log[1].func, 'Unity.MessagingIndicator.clearIndicators');30 assertEquals('Unity.Launcher.addAction', log[1].func, 'Unity.Launcher.addAction');
3131
32 var found = false, i;32 var found = false, i;
33 for (i = 0; i < out.length; i++) {33 for (i = 0; i < out.length; i++) {

Subscribers

People subscribed via source and target branches

to all changes: