Merge lp:~vorlon/summit/strptime-usage into lp:summit
Status: | Needs review |
---|---|
Proposed branch: | lp:~vorlon/summit/strptime-usage |
Merge into: | lp:summit |
Diff against target: |
33 lines (+8/-3) 2 files modified
summit/common/widgets.py (+6/-1) summit/version.py (+2/-2) |
To merge this branch: | bzr merge lp:~vorlon/summit/strptime-usage |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Hall (community) | Needs Information | ||
Review via email: mp+215540@code.launchpad.net |
Description of the change
It's quite possible that I've done something wrong, but from what I can see the decompress() function fails consistently when trying to parse an existing datetime setting from the database because it will never be in HH:MM AM/PM form, but always HH:MM:SS. So this change is needed to make the form submission work for me.
Unmerged revisions
- 224. By Steve Langasek
-
Make the custom DateTime widget nullable, like the upstream one is
- 223. By Steve Langasek
-
Apparently we can get this code path called with two different time formats; dunno why, but this addresses the problem at least for now
- 222. By Steve Langasek
-
Pass the right format string to strptime
I have no idea how this bug could have escaped notice for so long, but the
code is definitely unpacking a string in the wrong format. Fix a backtrace
when trying to submit registration forms for DebConf.
Steve,
I think you wanted to push this against lp:summit/production instead of lp:summit?