Merge lp:~voldyman/slingshot/fix-1199903 into lp:~elementary-pantheon/slingshot/trunk

Proposed by Akshay Shekher
Status: Merged
Approved by: David Gomes
Approved revision: 420
Merged at revision: 420
Proposed branch: lp:~voldyman/slingshot/fix-1199903
Merge into: lp:~elementary-pantheon/slingshot/trunk
Diff against target: 41 lines (+2/-11)
2 files modified
CMakeLists.txt (+2/-2)
src/SlingshotView.vala (+0/-9)
To merge this branch: bzr merge lp:~voldyman/slingshot/fix-1199903
Reviewer Review Type Date Requested Status
David Gomes (community) Approve
Review via email: mp+221211@code.launchpad.net

Commit message

Removed Gdx.X11 and Wnck dependency

Description of the change

Removed the code that uses Gdk.X!! for focus issues, those issues don't occur anymore.

To post a comment you must log in.
Revision history for this message
David Gomes (davidgomes) wrote :

Tested and it works just fine.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2014-02-24 15:30:13 +0000
+++ CMakeLists.txt 2014-05-28 11:51:54 +0000
@@ -54,7 +54,7 @@
54 message ("-- Zeitgeist integration disabled")54 message ("-- Zeitgeist integration disabled")
55endif ()55endif ()
5656
57set (CORE_DEPS "gobject-2.0;glib-2.0;gio-2.0;gio-unix-2.0;gee-0.8;libgnome-menu-3.0;libwnck-3.0;gdk-x11-3.0;${UNITY_DEPS};")57set (CORE_DEPS "gobject-2.0;glib-2.0;gio-2.0;gio-unix-2.0;gee-0.8;libgnome-menu-3.0;${UNITY_DEPS};")
58set (UI_DEPS "gtk+-3.0>=3.10.0;granite;${ZEITGEIST_DEPS};")58set (UI_DEPS "gtk+-3.0>=3.10.0;granite;${ZEITGEIST_DEPS};")
5959
60find_package (PkgConfig)60find_package (PkgConfig)
@@ -96,7 +96,7 @@
96# Comment this out to enable C compiler warnings96# Comment this out to enable C compiler warnings
97add_definitions (-w)97add_definitions (-w)
9898
99add_definitions (${DEPS_CFLAGS} -DGMENU_I_KNOW_THIS_IS_UNSTABLE -DWNCK_I_KNOW_THIS_IS_UNSTABLE -include config.h)99add_definitions (${DEPS_CFLAGS} -DGMENU_I_KNOW_THIS_IS_UNSTABLE -include config.h)
100link_libraries (${DEPS_LIBRARIES})100link_libraries (${DEPS_LIBRARIES})
101link_directories (${DEPS_LIBRARY_DIRS})101link_directories (${DEPS_LIBRARY_DIRS})
102102
103103
=== modified file 'src/SlingshotView.vala'
--- src/SlingshotView.vala 2014-05-24 23:01:41 +0000
+++ src/SlingshotView.vala 2014-05-28 11:51:54 +0000
@@ -650,15 +650,6 @@
650 set_focus(null);650 set_focus(null);
651 search_entry.grab_focus ();651 search_entry.grab_focus ();
652 set_modality ((Modality) view_selector.selected);652 set_modality ((Modality) view_selector.selected);
653
654 while (Gtk.events_pending ())
655 Gtk.main_iteration ();
656
657 var xid = Gdk.X11Window.get_xid (this.get_window ());
658 var w = Wnck.Window.get (xid);
659 Wnck.Screen.get_default ().force_update ();
660 if (w != null)
661 w.activate (Gdk.x11_get_server_time (this.get_window ()));
662 }653 }
663654
664 private void set_modality (Modality new_modality) {655 private void set_modality (Modality new_modality) {

Subscribers

People subscribed via source and target branches