Merge lp:~vila/bzr/430868-sig-domain into lp:bzr

Proposed by Vincent Ladeuil
Status: Merged
Merged at revision: not available
Proposed branch: lp:~vila/bzr/430868-sig-domain
Merge into: lp:bzr
Diff against target: None lines
To merge this branch: bzr merge lp:~vila/bzr/430868-sig-domain
Reviewer Review Type Date Requested Status
John A Meinel Approve
Review via email: mp+12079@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Vincent Ladeuil (vila) wrote :

The first submission didn't include a test to reproduce the bug.
Here it is.

Revision history for this message
John A Meinel (jameinel) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bzrlib/tests/per_bzrdir/test_bzrdir.py'
--- bzrlib/tests/per_bzrdir/test_bzrdir.py 2009-08-20 04:09:58 +0000
+++ bzrlib/tests/per_bzrdir/test_bzrdir.py 2009-09-18 17:19:15 +0000
@@ -28,6 +28,7 @@
28 bzrdir,28 bzrdir,
29 check,29 check,
30 errors,30 errors,
31 gpg,
31 lockdir,32 lockdir,
32 osutils,33 osutils,
33 repository,34 repository,
@@ -432,6 +433,27 @@
432 target = dir.clone(self.get_url('target'), revision_id='2')433 target = dir.clone(self.get_url('target'), revision_id='2')
433 raise TestSkipped('revision limiting not strict yet')434 raise TestSkipped('revision limiting not strict yet')
434435
436 def test_clone_bzrdir_branch_and_repo_fixed_user_id(self):
437 # Bug #430868 is about an email containing '.sig'
438 os.environ['BZR_EMAIL'] = 'murphy@host.sighup.org'
439 tree = self.make_branch_and_tree('commit_tree')
440 self.build_tree(['commit_tree/foo'])
441 tree.add('foo')
442 rev1 = tree.commit('revision 1')
443 tree_repo = tree.branch.repository
444 tree_repo.lock_write()
445 tree_repo.start_write_group()
446 tree_repo.sign_revision(rev1, gpg.LoopbackGPGStrategy(None))
447 tree_repo.commit_write_group()
448 tree_repo.unlock()
449 target = self.make_branch('target')
450 tree.branch.repository.copy_content_into(target.repository)
451 tree.branch.copy_content_into(target)
452 self.assertTrue(target.repository.has_revision(rev1))
453 self.assertEqual(
454 tree_repo.get_signature_text(rev1),
455 target.repository.get_signature_text(rev1))
456
435 def test_clone_bzrdir_branch_and_repo(self):457 def test_clone_bzrdir_branch_and_repo(self):
436 tree = self.make_branch_and_tree('commit_tree')458 tree = self.make_branch_and_tree('commit_tree')
437 self.build_tree(['commit_tree/foo'])459 self.build_tree(['commit_tree/foo'])