Merge lp:~vila/bzr/388725-progress-bar-config-option into lp:bzr
Proposed by
Vincent Ladeuil
Status: | Merged |
---|---|
Approved by: | John A Meinel |
Approved revision: | no longer in the source branch. |
Merged at revision: | 6564 |
Proposed branch: | lp:~vila/bzr/388725-progress-bar-config-option |
Merge into: | lp:bzr |
Diff against target: |
192 lines (+51/-32) 6 files modified
bzrlib/config.py (+7/-4) bzrlib/tests/blackbox/test_debug.py (+3/-4) bzrlib/tests/blackbox/test_diff.py (+4/-4) bzrlib/tests/blackbox/test_locale.py (+17/-11) bzrlib/ui/text.py (+16/-9) doc/en/release-notes/bzr-2.6.txt (+4/-0) |
To merge this branch: | bzr merge lp:~vila/bzr/388725-progress-bar-config-option |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
John A Meinel | Approve | ||
Review via email: mp+125114@code.launchpad.net |
Commit message
Add a config option for the progress bar type.
Description of the change
Add a config option for the progress bar type.
I fixed this bug with a simple grep, splitting tests between those that use
'-Oprogress_
pleasantly surprised to see this was so trivial do decide... it demonstrates
(for those that weren't convinced, slightly including myself ;) that there
is indeed a good use case to allow both the env var and the config option.
To post a comment you must log in.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 9/19/2012 11:16 AM, Vincent Ladeuil wrote: /bugs.launchpad .net/duplicity/ +bug/388725 /code.launchpad .net/~vila/ bzr/388725- progress- bar-config- option/ +merge/ 125114 bar=[none| text]' and those that still use the
> Vincent Ladeuil has proposed merging
> lp:~vila/bzr/388725-progress-bar-config-option into lp:bzr.
>
> Requested reviews: bzr-core (bzr-core) Related bugs: Bug #388725
> in Duplicity: "Report when duplicity is 'done' with restoring a
> file" https:/
>
> For more details, see:
> https:/
>
>
>
Add a config option for the progress bar type.
>
> I fixed this bug with a simple grep, splitting tests between those
> that use '-Oprogress_
> env bar and was pleasantly surprised to see this was so trivial do
> decide... it demonstrates (for those that weren't convinced,
> slightly including myself ;) that there is indeed a good use case
> to allow both the env var and the config option.
>
merge: approve
Looks good.
John
=:->
-----BEGIN PGP SIGNATURE----- www.enigmail. net/
ZcooACgkQJdeBCY SNAAND4ACgiLVx+ BUb82iYjIgoNNpb rF5I fXIyCkz1G1TlVOF hG
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAlB
9UIAnRG5km6Bain
=3puI
-----END PGP SIGNATURE-----