Merge lp:~vanvugt/ubuntu-system-settings/brightness-slider-title into lp:ubuntu-system-settings

Proposed by Daniel van Vugt
Status: Needs review
Proposed branch: lp:~vanvugt/ubuntu-system-settings/brightness-slider-title
Merge into: lp:ubuntu-system-settings
Diff against target: 23 lines (+1/-5)
1 file modified
plugins/brightness/PageComponent.qml (+1/-5)
To merge this branch: bzr merge lp:~vanvugt/ubuntu-system-settings/brightness-slider-title
Reviewer Review Type Date Requested Status
Ubuntu Touch System Settings Pending
Review via email: mp+317738@code.launchpad.net

Commit message

Use the proper text attribute for the "Display brightness" slider.

Less code, and a more consistent layout (since most other sliders do
it this way already).

To post a comment you must log in.

Unmerged revisions

1761. By Daniel van Vugt

Use the proper text attribute for the "Display brightness" slider.

Less code, and a more consistent layout (since most other sliders do
it this way already).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'plugins/brightness/PageComponent.qml'
--- plugins/brightness/PageComponent.qml 2016-12-06 15:38:02 +0000
+++ plugins/brightness/PageComponent.qml 2017-02-20 04:00:37 +0000
@@ -80,11 +80,6 @@
80 anchors.left: parent.left80 anchors.left: parent.left
81 anchors.right: parent.right81 anchors.right: parent.right
8282
83 ListItem.Standard {
84 text: i18n.tr("Display brightness")
85 showDivider: false
86 }
87
88 /* Use the SliderMenu component instead of the Slider to avoid binding83 /* Use the SliderMenu component instead of the Slider to avoid binding
89 issues on valueChanged until LP: #1388094 is fixed.84 issues on valueChanged until LP: #1388094 is fixed.
90 */85 */
@@ -93,6 +88,7 @@
93 objectName: "sliderMenu"88 objectName: "sliderMenu"
94 enabled: indicatorPower.brightness.state != null89 enabled: indicatorPower.brightness.state != null
95 live: true90 live: true
91 text: i18n.tr("Display brightness")
96 minimumValue: 0.092 minimumValue: 0.0
97 maximumValue: 100.093 maximumValue: 100.0
98 minIcon: "image://theme/display-brightness-min"94 minIcon: "image://theme/display-brightness-min"

Subscribers

People subscribed via source and target branches