1
=== modified file 'src/platforms/android/server/hwc_device.cpp'
2
--- src/platforms/android/server/hwc_device.cpp	2017-01-18 02:29:37 +0000
3
+++ src/platforms/android/server/hwc_device.cpp	2017-01-23 03:41:38 +0000
4
@@ -56,8 +56,7 @@
5
56
        //TODO: enable planeAlpha for (hwc version >= 1.2), 90 deg rotation
56
        //TODO: enable planeAlpha for (hwc version >= 1.2), 90 deg rotation
6
57
        static glm::mat4 const identity;
57
        static glm::mat4 const identity;
7
58
        if (plane_alpha_is_translucent(*renderable) ||
58
        if (plane_alpha_is_translucent(*renderable) ||
10
59
           (renderable->transformation() != identity) ||
59
            renderable->transformation() != identity)
9
60
           (renderable->swap_interval() == 0)) //See LP: #1369763
11
61
        {
60
        {
12
62
            return false;
61
            return false;
13
63
        }
62
        }
14
64
63
15
=== modified file 'tests/unit-tests/platforms/android/server/test_hwc_device.cpp'
16
--- tests/unit-tests/platforms/android/server/test_hwc_device.cpp	2017-01-23 03:41:38 +0000
17
+++ tests/unit-tests/platforms/android/server/test_hwc_device.cpp	2017-01-23 03:41:38 +0000
18
@@ -600,10 +600,8 @@
19
600
    EXPECT_FALSE(device.compatible_renderlist(renderlist));
600
    EXPECT_FALSE(device.compatible_renderlist(renderlist));
20
601
}
601
}
21
602
602
26
603
//LP: #1369763. We could get swapinterval 0 to work with overlays, but we'd need
603
// Regression test for LP: #1657755
27
604
//the vsync signal from hwc to reach the client, so the client can rate-limit its submissions.
604
TEST_F(HwcDevice, accepts_list_containing_interval_0)
24
605
// Update: We have client-side vsync now so it should be possible to do this...
25
606
TEST_F(HwcDevice, rejects_list_containing_interval_0)
28
607
{
605
{
29
608
    using namespace ::testing;
606
    using namespace ::testing;
30
609
607
31
@@ -614,7 +612,7 @@
32
614
        .WillByDefault(Return(0));
612
        .WillByDefault(Return(0));
33
615
613
34
616
    mg::RenderableList renderlist{renderable};
614
    mg::RenderableList renderlist{renderable};
36
617
    EXPECT_FALSE(device.compatible_renderlist(renderlist));
615
    EXPECT_TRUE(device.compatible_renderlist(renderlist));
37
618
}
616
}
38
619
617
39
620
//TODO: we could accept a 90 degree transform
618
//TODO: we could accept a 90 degree transform
Reviewer	Review Type	Date Requested	Status
Mir CI Bot	continuous-integration	2017-01-20	Approve on 2017-01-24
Cemil Azizoglu (community)			Approve on 2017-01-23
Kevin DuBois (community)		2017-01-20	Approve on 2017-01-23
Review via email: mp+315195@code.launchpad.net