Merge ~utkarsh/ubuntu/+source/virglrenderer:merge-lp1959175-jammy into ubuntu/+source/virglrenderer:debian/experimental

Proposed by Utkarsh Gupta
Status: Merged
Merge reported by: Utkarsh Gupta
Merged at revision: 3b804f04679012ec77b4eebe44c84110555ba6b7
Proposed branch: ~utkarsh/ubuntu/+source/virglrenderer:merge-lp1959175-jammy
Merge into: ubuntu/+source/virglrenderer:debian/experimental
Diff against target: 95 lines (+56/-1)
4 files modified
debian/changelog (+19/-0)
debian/control (+2/-1)
debian/patches/lp-1950941-vrend-fix-boundary-check-for-SSBO-state-update.patch (+34/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Andreas Hasenack Approve
Canonical Server Pending
git-ubuntu import Pending
Review via email: mp+416057@code.launchpad.net

Description of the change

Hello,

This is a very trivial merge of virglrenderer. The delta is already upstream and Debian will pick it up as soon as they do a new upstream release.

PPA could be found at: https://launchpad.net/~utkarsh/+archive/ubuntu/temporary-stuff.

Let me know what you think! :D

To post a comment you must log in.
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

symbols file just had additions
no soname change
simple delta, kept

I can't tell if this version bump will require qemu changes, I assume not because the bug asking for it was filed by Christian and he didn't mention any.

+1

review: Approve
Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

Thank you, Andreas! \o/

$ dput ubuntu ../virglrenderer_0.9.1-1\~exp1ubuntu1_source.changes
Checking signature on .changes
gpg: ../virglrenderer_0.9.1-1~exp1ubuntu1_source.changes: Valid signature from 823E967606C34B96
Checking signature on .dsc
gpg: ../virglrenderer_0.9.1-1~exp1ubuntu1.dsc: Valid signature from 823E967606C34B96
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading virglrenderer_0.9.1-1~exp1ubuntu1.dsc: done.
  Uploading virglrenderer_0.9.1.orig.tar.bz2: done.
  Uploading virglrenderer_0.9.1-1~exp1ubuntu1.debian.tar.xz: done.
  Uploading virglrenderer_0.9.1-1~exp1ubuntu1_source.buildinfo: done.
  Uploading virglrenderer_0.9.1-1~exp1ubuntu1_source.changes: done.
Successfully uploaded packages.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

This migrated, could you please set this MP to "merged"?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index 095e7bb..75ecc99 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
1virglrenderer (0.9.1-1~exp1ubuntu1) jammy; urgency=medium
2
3 * Merge with Debian unstable (LP: #1959175). Remaining changes:
4 - d/p/lp-1950941*: fix out of bounds check (LP #1950941)
5
6 -- Utkarsh Gupta <utkarsh@ubuntu.com> Fri, 25 Feb 2022 02:23:43 +0530
7
1virglrenderer (0.9.1-1~exp1) experimental; urgency=medium8virglrenderer (0.9.1-1~exp1) experimental; urgency=medium
29
3 * New upstream version 0.9.110 * New upstream version 0.9.1
@@ -11,6 +18,18 @@ virglrenderer (0.9.0-1~exp1) experimental; urgency=medium
1118
12 -- Gert Wollny <gewo@debian.org> Tue, 06 Apr 2021 15:24:55 +020019 -- Gert Wollny <gewo@debian.org> Tue, 06 Apr 2021 15:24:55 +0200
1320
21virglrenderer (0.8.2-5ubuntu1) jammy; urgency=medium
22
23 * d/p/lp-1950941*: fix out of bounds check (LP: #1950941)
24
25 -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Thu, 02 Dec 2021 08:34:48 +0100
26
27virglrenderer (0.8.2-5build1) impish; urgency=medium
28
29 * No-change rebuild to build packages with zstd compression.
30
31 -- Matthias Klose <doko@ubuntu.com> Thu, 07 Oct 2021 12:26:08 +0200
32
14virglrenderer (0.8.2-5) unstable; urgency=medium33virglrenderer (0.8.2-5) unstable; urgency=medium
1534
16 [ Christian Ehrhardt ]35 [ Christian Ehrhardt ]
diff --git a/debian/control b/debian/control
index a256720..685f907 100644
--- a/debian/control
+++ b/debian/control
@@ -1,7 +1,8 @@
1Source: virglrenderer1Source: virglrenderer
2Section: libs2Section: libs
3Priority: optional3Priority: optional
4Maintainer: Gert Wollny <gewo@debian.org>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5XSBC-Original-Maintainer: Gert Wollny <gewo@debian.org>
5Build-Depends: check,6Build-Depends: check,
6 debhelper-compat (= 12),7 debhelper-compat (= 12),
7 libdrm-dev,8 libdrm-dev,
diff --git a/debian/patches/lp-1950941-vrend-fix-boundary-check-for-SSBO-state-update.patch b/debian/patches/lp-1950941-vrend-fix-boundary-check-for-SSBO-state-update.patch
8new file mode 1006449new file mode 100644
index 0000000..02a6559
--- /dev/null
+++ b/debian/patches/lp-1950941-vrend-fix-boundary-check-for-SSBO-state-update.patch
@@ -0,0 +1,34 @@
1From 673f4d0c1dfe78f66e8d7f036c619065800022de Mon Sep 17 00:00:00 2001
2From: Chia-I Wu <olvaffe@gmail.com>
3Date: Wed, 21 Jul 2021 13:08:12 -0700
4Subject: [PATCH] vrend: fix boundary check for SSBO state update
5
6(PIPE_MAX_SHADER_BUFFERS - num_ssbo) can underflow.
7
8Signed-off-by: Chia-I Wu <olvaffe@gmail.com>
9Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
10
11Origin: upstream, https://gitlab.freedesktop.org/virgl/virglrenderer/-/commit/673f4d0c1dfe78f66e8d7f036c619065800022de
12Bug-Ubuntu: https://bugs.launchpad.net/bugs/1950941
13Last-Update: 2021-12-02
14
15---
16 src/vrend_decode.c | 2 +-
17 1 file changed, 1 insertion(+), 1 deletion(-)
18
19diff --git a/src/vrend_decode.c b/src/vrend_decode.c
20index 35ccc23..9fc3552 100644
21--- a/src/vrend_decode.c
22+++ b/src/vrend_decode.c
23@@ -1208,7 +1208,7 @@ static int vrend_decode_set_shader_buffers(struct vrend_context *ctx, const uint
24 return 0;
25
26 if (start_slot > PIPE_MAX_SHADER_BUFFERS ||
27- start_slot > PIPE_MAX_SHADER_BUFFERS - num_ssbo)
28+ num_ssbo > PIPE_MAX_SHADER_BUFFERS - start_slot)
29 return EINVAL;
30
31 for (uint32_t i = 0; i < num_ssbo; i++) {
32--
332.34.0
34
diff --git a/debian/patches/series b/debian/patches/series
0new file mode 10064435new file mode 100644
index 0000000..55792fb
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
1lp-1950941-vrend-fix-boundary-check-for-SSBO-state-update.patch

Subscribers

People subscribed via source and target branches