Merge lp:~unity-api-team/telephony-service/file-based-infographics into lp:telephony-service

Proposed by Pete Woods
Status: Approved
Approved by: Pete Woods
Approved revision: 838
Proposed branch: lp:~unity-api-team/telephony-service/file-based-infographics
Merge into: lp:telephony-service
Diff against target: 55 lines (+10/-2)
4 files modified
CMakeLists.txt (+7/-0)
debian/control (+1/-1)
debian/telephony-service.install (+1/-0)
indicator/metrics.cpp (+1/-1)
To merge this branch: bzr merge lp:~unity-api-team/telephony-service/file-based-infographics
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Gustavo Pichorim Boiko (community) Needs Fixing
Review via email: mp+224105@code.launchpad.net

Commit message

Support the new libusermetrics hook

Description of the change

Support the new libusermetrics hook

Depends on lp:~unity-team/libusermetrics/file-based-infographics being merged

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
834. By Pete Woods

Work around breakage resulting from Qt5.3

See: https://qt.gitorious.org/qt/digia-qt/commit/e1ac82f713ab2a766ae518f3ec7a7f76689acb48

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
835. By Pete Woods

Set the APP_ID

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Can you please remove the workarounds in greeter contacts' tests? Also, can you please merge the latest changes from trunk in this MR?

Thanks.

review: Needs Fixing
836. By Pete Woods

Revert the workaround

837. By Pete Woods

Merge trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
838. By Pete Woods

Merge trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
839. By Pete Woods

Merge trunk

Revision history for this message
MichaƂ Sawicz (saviq) wrote :

Text conflict in indicator/metrics.cpp
1 conflicts encountered.

840. By Gustavo Pichorim Boiko

Merge latest changes from trunk.

Unmerged revisions

840. By Gustavo Pichorim Boiko

Merge latest changes from trunk.

839. By Pete Woods

Merge trunk

838. By Pete Woods

Merge trunk

837. By Pete Woods

Merge trunk

836. By Pete Woods

Revert the workaround

835. By Pete Woods

Set the APP_ID

834. By Pete Woods

Work around breakage resulting from Qt5.3

See: https://qt.gitorious.org/qt/digia-qt/commit/e1ac82f713ab2a766ae518f3ec7a7f76689acb48

833. By Pete Woods

Support the new libusermetrics hook

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2014-08-05 20:04:00 +0000
+++ CMakeLists.txt 2014-09-02 17:10:50 +0000
@@ -86,6 +86,13 @@
86add_definitions(-std=c++11)86add_definitions(-std=c++11)
8787
88set(DATA_DIR "${CMAKE_SOURCE_DIR}/data")88set(DATA_DIR "${CMAKE_SOURCE_DIR}/data")
89
90# install infographics source hook
91install(
92 FILES "${DATA_DIR}/telephony-service.json"
93 DESTINATION "${CMAKE_INSTALL_DATADIR}/libusermetrics/sources/"
94 )
95
89# install assets96# install assets
90set(ASSETS_DIR assets)97set(ASSETS_DIR assets)
91install(DIRECTORY ${ASSETS_DIR} DESTINATION ${TELEPHONY_SERVICE_DIR})98install(DIRECTORY ${ASSETS_DIR} DESTINATION ${TELEPHONY_SERVICE_DIR})
9299
=== added file 'data/telephony-service.json'
=== modified file 'debian/control'
--- debian/control 2014-08-19 15:27:08 +0000
+++ debian/control 2014-09-02 17:10:50 +0000
@@ -30,7 +30,7 @@
30 qtdeclarative5-ubuntu-ui-toolkit-plugin,30 qtdeclarative5-ubuntu-ui-toolkit-plugin,
31 qtmultimedia5-dev (>= 5.0),31 qtmultimedia5-dev (>= 5.0),
32 qtpim5-dev (>= 5),32 qtpim5-dev (>= 5),
33 libusermetricsinput1-dev,33 libusermetricsinput1-dev (>= 1.2.0),
34 telepathy-mission-control-5,34 telepathy-mission-control-5,
35 xvfb,35 xvfb,
36Standards-Version: 3.9.436Standards-Version: 3.9.4
3737
=== modified file 'debian/telephony-service.install'
--- debian/telephony-service.install 2014-03-24 18:53:27 +0000
+++ debian/telephony-service.install 2014-09-02 17:10:50 +0000
@@ -14,5 +14,6 @@
14usr/share/polkit-1/actions/*TelephonyService*.policy14usr/share/polkit-1/actions/*TelephonyService*.policy
15usr/share/telepathy/clients/TelephonyService*.client15usr/share/telepathy/clients/TelephonyService*.client
16usr/share/telephony-service/assets/*16usr/share/telephony-service/assets/*
17usr/share/libusermetrics
17var/lib/polkit-1/localauthority/10-vendor.d/*TelephonyService*.pkla18var/lib/polkit-1/localauthority/10-vendor.d/*TelephonyService*.pkla
18upstart/telephony-service-indicator.conf /usr/share/upstart/sessions19upstart/telephony-service-indicator.conf /usr/share/upstart/sessions
1920
=== modified file 'indicator/metrics.cpp'
--- indicator/metrics.cpp 2014-08-20 09:35:55 +0000
+++ indicator/metrics.cpp 2014-09-02 17:10:50 +0000
@@ -38,7 +38,7 @@
38 QObject(parent)38 QObject(parent)
39{39{
40 try {40 try {
41 mMetricManager.reset(MetricManager::getInstance());41 mMetricManager.reset(MetricManager::getInstance(APP_ID));
42 mMetrics[SentMessages] = mMetricManager->add(MetricParameters(MESSAGES_SENT_STATISTICS_ID).formatString(GettextMarkExtraction("<b>%1</b> text messages sent today"))42 mMetrics[SentMessages] = mMetricManager->add(MetricParameters(MESSAGES_SENT_STATISTICS_ID).formatString(GettextMarkExtraction("<b>%1</b> text messages sent today"))
43 .emptyDataString(GettextMarkExtraction("No text messages sent today")).textDomain(APP_ID).minimum(0.0));43 .emptyDataString(GettextMarkExtraction("No text messages sent today")).textDomain(APP_ID).minimum(0.0));
44 mMetrics[ReceivedMessages] = mMetricManager->add(MetricParameters(MESSAGES_RECEIVED_STATISTICS_ID).formatString(GettextMarkExtraction("<b>%1</b> text messages received today"))44 mMetrics[ReceivedMessages] = mMetricManager->add(MetricParameters(MESSAGES_RECEIVED_STATISTICS_ID).formatString(GettextMarkExtraction("<b>%1</b> text messages received today"))

Subscribers

People subscribed via source and target branches