Merge lp:~unity-api-team/camera-app/infographics-translations into lp:camera-app

Proposed by Pete Woods
Status: Needs review
Proposed branch: lp:~unity-api-team/camera-app/infographics-translations
Merge into: lp:camera-app
Diff against target: 38 lines (+5/-5)
2 files modified
camera-app.qml (+4/-4)
po/CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp:~unity-api-team/camera-app/infographics-translations
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+250616@code.launchpad.net

Commit message

Perform infographic translations server-side, instead of client-side

Description of the change

Perform infographic translations server-side, instead of client-side

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Florian Boucault (fboucault) wrote :

Thanks Pete!
Any chance you could fix https://bugs.launchpad.net/camera-app/+bug/1323373 while you are at it? :)

Unmerged revisions

519. By Pete Woods

Tag infographic strings for extraction, rather than translate directly

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'camera-app.qml'
--- camera-app.qml 2015-01-25 14:18:09 +0000
+++ camera-app.qml 2015-02-23 13:09:58 +0000
@@ -218,8 +218,8 @@
218 Metric {218 Metric {
219 id: metricPhotos219 id: metricPhotos
220 name: "camera-photos"220 name: "camera-photos"
221 format: i18n.tr("<b>%1</b> photos taken today")221 format: i18n.tag("<b>%1</b> photos taken today")
222 emptyFormat: i18n.tr("No photos taken today")222 emptyFormat: i18n.tag("No photos taken today")
223 domain: "camera-app"223 domain: "camera-app"
224 minimum: 0.0224 minimum: 0.0
225 }225 }
@@ -227,8 +227,8 @@
227 Metric {227 Metric {
228 id: metricVideos228 id: metricVideos
229 name: "camera-videos"229 name: "camera-videos"
230 format: i18n.tr("<b>%1</b> videos recorded today")230 format: i18n.tag("<b>%1</b> videos recorded today")
231 emptyFormat: i18n.tr("No videos recorded today")231 emptyFormat: i18n.tag("No videos recorded today")
232 domain: "camera-app"232 domain: "camera-app"
233 minimum: 0.0233 minimum: 0.0
234 }234 }
235235
=== modified file 'po/CMakeLists.txt'
--- po/CMakeLists.txt 2014-09-05 12:04:54 +0000
+++ po/CMakeLists.txt 2015-02-23 13:09:58 +0000
@@ -18,7 +18,7 @@
18 --from-code=UTF-818 --from-code=UTF-8
19 --c++ --qt --add-comments=TRANSLATORS19 --c++ --qt --add-comments=TRANSLATORS
20 --keyword=tr --keyword=N_ --keyword=tr:1,220 --keyword=tr --keyword=N_ --keyword=tr:1,2
21 --keyword=QT_TR_NOOP21 --keyword=QT_TR_NOOP --keyword=tag
22 --package-name=camera-app22 --package-name=camera-app
23 --copyright-holder='Canonical Ltd.'23 --copyright-holder='Canonical Ltd.'
24 ${I18N_SRC_FILES})24 ${I18N_SRC_FILES})

Subscribers

People subscribed via source and target branches