Merge lp:~ubuntubmw/intltool/fix-cache-race into lp:intltool
Proposed by
Bernhard M. Wiedemann
Status: | Merged |
---|---|
Approved by: | Данило Шеган |
Approved revision: | 748 |
Merged at revision: | 748 |
Proposed branch: | lp:~ubuntubmw/intltool/fix-cache-race |
Merge into: | lp:intltool |
Diff against target: |
34 lines (+5/-0) 1 file modified
intltool-merge.in (+5/-0) |
To merge this branch: | bzr merge lp:~ubuntubmw/intltool/fix-cache-race |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Данило Шеган | Approve | ||
Review via email: mp+324278@code.launchpad.net |
Description of the change
Avoid a race where some processes try to use a partial cache file
that is still being written to.
Note that we release the lock before load_cache,
because if we got the lock, the cache is already completely written
and it is OK to have multiple parallel readers
Without this patch, translation files would randomly miss translations
for some or all languages.
fixes bug #1687644
maybe also bug #986897
To post a comment you must log in.
Looks good, thanks for the fix!