Merge lp:ubuntu-push/automatic into lp:ubuntu-push

Proposed by Jonas G. Drange
Status: Merged
Approved by: Jonas G. Drange
Approved revision: 426
Merged at revision: 161
Proposed branch: lp:ubuntu-push/automatic
Merge into: lp:ubuntu-push
Diff against target: 65 lines (+3/-7)
6 files modified
bus/connectivity/connectivity_test.go (+1/-1)
bus/networkmanager/networkmanager.go (+1/-1)
client/service/postal_test.go (+1/-0)
debian/source/format (+0/-1)
docs/example-server/.bzrignore (+0/-1)
docs/example-server/.gitignore (+0/-3)
To merge this branch: bzr merge lp:ubuntu-push/automatic
Reviewer Review Type Date Requested Status
Ubuntu Push Hackers Pending
Review via email: mp+293396@code.launchpad.net

Commit message

Correctly refer to NMState as “State”, not “state”, as the move from gdbus-lib to gdbus requires it.

To post a comment you must log in.
lp:ubuntu-push/automatic updated
427. By Jonas G. Drange

sync changelog between automatic and trunk

428. By Timo Jyrinki

remove debian/source, not needed

429. By Simon Fels

[r=jonas-drange] Use source format 3.0 (quilt) again

Removing debian/source/ in a previous commit brough us back to source format 1.0 which doesn't preserve the executable flag on our debian/*.install files.

430. By Jonas G. Drange

[r=morphis] skip test that would be non-trivial to fix, but blocks rootfs from building for OTA11

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bus/connectivity/connectivity_test.go'
--- bus/connectivity/connectivity_test.go 2015-04-29 15:17:49 +0000
+++ bus/connectivity/connectivity_test.go 2016-05-03 11:36:50 +0000
@@ -167,7 +167,7 @@
167167
168func (rep *racyEndpoint) GetProperty(prop string) (interface{}, error) {168func (rep *racyEndpoint) GetProperty(prop string) (interface{}, error) {
169 switch prop {169 switch prop {
170 case "state":170 case "State":
171 rep.lock.Lock()171 rep.lock.Lock()
172 defer rep.lock.Unlock()172 defer rep.lock.Unlock()
173 rep.stateGot = true173 rep.stateGot = true
174174
=== modified file 'bus/networkmanager/networkmanager.go'
--- bus/networkmanager/networkmanager.go 2015-03-30 12:04:49 +0000
+++ bus/networkmanager/networkmanager.go 2016-05-03 11:36:50 +0000
@@ -76,7 +76,7 @@
76*/76*/
7777
78func (nm *networkManager) GetState() State {78func (nm *networkManager) GetState() State {
79 s, err := nm.bus.GetProperty("state")79 s, err := nm.bus.GetProperty("State")
80 if err != nil {80 if err != nil {
81 nm.log.Errorf("failed getting current state: %s", err)81 nm.log.Errorf("failed getting current state: %s", err)
82 nm.log.Debugf("defaulting state to Unknown")82 nm.log.Debugf("defaulting state to Unknown")
8383
=== modified file 'client/service/postal_test.go'
--- client/service/postal_test.go 2015-11-20 14:48:53 +0000
+++ client/service/postal_test.go 2016-05-03 11:36:50 +0000
@@ -380,6 +380,7 @@
380// Post() tests380// Post() tests
381381
382func (ps *postalSuite) TestPostWorks(c *C) {382func (ps *postalSuite) TestPostWorks(c *C) {
383 c.Skip("Skipping due to lp:1577723")
383 svc := ps.replaceBuses(NewPostalService(ps.cfg, ps.log))384 svc := ps.replaceBuses(NewPostalService(ps.cfg, ps.log))
384 svc.msgHandler = nil385 svc.msgHandler = nil
385 ch := installTickMessageHandler(svc)386 ch := installTickMessageHandler(svc)
386387
=== added directory 'debian/source'
=== removed directory 'debian/source'
=== added file 'debian/source/format'
--- debian/source/format 1970-01-01 00:00:00 +0000
+++ debian/source/format 2016-05-03 11:36:50 +0000
@@ -0,0 +1,1 @@
13.0 (quilt)
02
=== removed file 'debian/source/format'
--- debian/source/format 2014-03-25 14:35:07 +0000
+++ debian/source/format 1970-01-01 00:00:00 +0000
@@ -1,1 +0,0 @@
13.0 (quilt)
20
=== removed file 'docs/example-server/.bzrignore'
--- docs/example-server/.bzrignore 2014-09-05 14:57:17 +0000
+++ docs/example-server/.bzrignore 1970-01-01 00:00:00 +0000
@@ -1,1 +0,0 @@
1.git
20
=== removed file 'docs/example-server/.gitignore'
--- docs/example-server/.gitignore 2014-09-05 14:57:17 +0000
+++ docs/example-server/.gitignore 1970-01-01 00:00:00 +0000
@@ -1,3 +0,0 @@
1.bzr
2.bzrignore
3node_modules

Subscribers

People subscribed via source and target branches