Merge lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm-norootdelay-cosmic into lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm

[Steve Langasek]

Don't set rootdelay on the kernel commandline.

This is interpreted differently by the kernel (== fixed delay) vs. in the
Debian initramfs code (== max time to wait before erroring); so what worked
for raising the timeout for images with initramfs causes a boot delay for
images booting without initramfs.

Since the "fabric issue" that this worked around is lost in the mists of
time (2012), we should just stop setting rootdelay.

[Philip Roche (philroche)]

+1

I have tested this change using ubuntu-old-fashioned and boot times were not affected.

1min 10.444s
1min 1.984s
1min 2.488s
58.403s
59.143s
58.389s
1min 856ms
1min 9.656s
1min 21.010s
1min 12.514s

review: Approve

[Dan Watkins (oddbloke)]

I'm not convinced (a) that we should make this change in release week, and (b) that we actually need it; the cosmic images aren't going to go out booting without initrds, and we should be focused on landing the Azure-on-Alan work and backporting it instead of maintaining these scripts.

(If we really want to, we could land it in the dd scripts for the hopefully-short period of time before we switch to Alan publication.)

review: Needs Information

[Philip Roche (philroche)]

As we have yet to receive any feedback about the minimal image yet and we won't be building minimal images with this template then I am +1 on not merging this this week.

[Dan Watkins (oddbloke)]

Steve, I believe we still want to apply this, right? If so, could you resubmit for disco, please?

review: Needs Resubmitting

[Robert C Jennings (rcj)]

This has been removed and the MP is no longer necessary.

review: Disapprove

Unmerged revisions

811. By Steve Langasek on 2018-10-11

Don't set rootdelay on the kernel commandline.

This is interpreted differently by the kernel (== fixed delay) vs. in the
Debian initramfs code (== max time to wait before erroring); so what worked
for raising the timeout for images with initramfs causes a boot delay for
images booting without initramfs.

Since the "fabric issue" that this worked around is lost in the mists of
time (2012), we should just stop setting rootdelay.

=== modified file 'templates/img-azure-18.10-addin.tmpl'
--- templates/img-azure-18.10-addin.tmpl	2018-10-11 16:07:30 +0000
+++ templates/img-azure-18.10-addin.tmpl	2018-10-11 21:50:14 +0000
@@ -6,7 +6,7 @@
 ${CLOUD_IMG_STR}
 
 # Set the default commandline
-GRUB_CMDLINE_LINUX_DEFAULT="console=tty1 console=ttyS0 earlyprintk=ttyS0 rootdelay=300"
+GRUB_CMDLINE_LINUX_DEFAULT="console=tty1 console=ttyS0 earlyprintk=ttyS0"
 
 # Set the grub console type
 GRUB_TERMINAL=serial