Merge ~ubuntu-core-dev/grub/+git/ubuntu:sil2100/use-auto-nvram into ~ubuntu-core-dev/grub/+git/ubuntu:ubuntu
Proposed by
Łukasz Zemczak
Status: | Rejected |
---|---|
Rejected by: | Łukasz Zemczak |
Proposed branch: | ~ubuntu-core-dev/grub/+git/ubuntu:sil2100/use-auto-nvram |
Merge into: | ~ubuntu-core-dev/grub/+git/ubuntu:ubuntu |
Diff against target: |
25 lines (+2/-1) 2 files modified
debian/changelog (+1/-0) debian/postinst.in (+1/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Steve Langasek | Disapprove | ||
Review via email: mp+345340@code.launchpad.net |
Commit message
debian/postinst.in: use --auto-nvram with grub-install calls.
Description of the change
debian/postinst.in: use --auto-nvram with grub-install calls.
To post a comment you must log in.
This doesn't look correct to me. The debian/postinst.in is used to generate the postinst of (among others) grub-efi-amd64 and grub-pc. In the EFI+BIOS coinstallability case, I would expect to see grub-pc installed, but not grub-efi-amd64: we would only install shim-signed + grub-efi-amd64-bin (+signed). Therefore, the one version of the script that actually *cares* about --auto-nvram is the one we would normally not expect to have installed.
Also see the $NO_NVRAM variable elsewhere in the code, which is specifically set only for EFI packages and passed as an argument to run_grub_install. If any changes should be made to this script to support --auto-nvram (which I think is unnecessary), they should be made there.