Merge lp:~twom/loggerhead/javascript-context-selector into lp:loggerhead

[Tom Wardill]

Fix context number

Entering a new value in the "Lines of context" box should update the relevant values.
There doesn't appear to be any method (that I can see) of this causing a reload of the data, so a manual refresh of the page is required.

[Colin Watson (cjwatson)]

review: Approve

=== modified file 'loggerhead/static/javascript/diff.js'
--- loggerhead/static/javascript/diff.js	2020-09-11 10:05:41 +0000
+++ loggerhead/static/javascript/diff.js	2020-09-11 10:05:41 +0000
@@ -168,18 +168,18 @@
 var original_diff_download_link = null;
 
 function compute_diff_links() {
-  var numlines = $('#contextLines').value;
+  var numlines = $('#contextLines').val();
   $('.diff').each(
     function(i, item)
     {
       item.collapsable.source = global_path + '+filediff/' + link_data[item.id] + '?context=' + numlines;
     });
-  if(original_diff_download_link == null) original_diff_download_link = $('#download_link').href;
-  $('#download_link').href = original_diff_download_link + '?context=' + numlines;
+  if(original_diff_download_link == null) original_diff_download_link = $('#download_link').attr('href');
+  $('#download_link').attr('href', original_diff_download_link + '?context=' + numlines);
 }
 
 function get_num_lines() {
-  var numlines = $('#contextLines').value;
+  var numlines = $('#contextLines').val();
   return numlines;
 }
 
@@ -197,7 +197,7 @@
     }
     var diffs = $('.diff');
     if (diffs == null) return;
-    var numlines = $('#contextLines').value;
+    var numlines = $('#contextLines').val();
     diffs.each(
       function(i, item)
       {
@@ -206,7 +206,7 @@
           'click',
           function(e) {
             e.preventDefault();
-            item.collapsable.source = global_path + '+filediff/' + link_data[item.id] + '?context=' + $('#contextLines').value;
+            item.collapsable.source = global_path + '+filediff/' + link_data[item.id] + '?context=' + $('#contextLines').val();
             collapsable.toggle();
           });
         var collapsable = new Collapsable(