Merge lp:~twom/loggerhead/animation-binding into lp:loggerhead

[Tom Wardill]

Fix animation binding and item iteration

The move to jQuery needs some adjustment in how animation callbacks work.
The callback is handed the DOM object, not the javascript object, so `this` refers to the wrong object. Use `.bind(this)` to ensure we have the correct object.
Also fix the arguments for iteration.

[Colin Watson (cjwatson)]

review: Approve

=== modified file 'loggerhead/static/javascript/custom.js'
--- loggerhead/static/javascript/custom.js	2020-06-04 19:43:36 +0000
+++ loggerhead/static/javascript/custom.js	2020-09-09 16:46:30 +0000
@@ -106,7 +106,7 @@
        if (this._loading) return;
        if (callback) callback();
        this.is_open = true;
-     });
+     }.bind(this));
 }
 
 Collapsable.prototype._load_finished = function(data, callback)
@@ -174,7 +174,7 @@
 
 Collapsable.prototype.open = function(callback)
 {
-  this.expand_icon.src = expanded_icon_path;
+  this.expand_icon[0].src = expanded_icon_path;
 
   this._ensure_container();
 
@@ -223,7 +223,7 @@
 
   var anim = $(this.container).animate(
       { marginBottom: [0, close_height - open_height]},
-      0.2, "swing", this.closeComplete);
+      0.2, "swing", this.closeComplete.bind(this));
 };
 
 Collapsable.prototype.closeComplete = function () {
@@ -232,7 +232,7 @@
     $(this.close_node).css({'display': 'block'});
   }
   $(this.container).css({'marginBottom': 0});
-  this.expand_icon.set('src', collapsed_icon_path);
+  this.expand_icon[0].src = collapsed_icon_path;
   this.is_open = false;
 };
 
 
=== modified file 'loggerhead/static/javascript/diff.js'
--- loggerhead/static/javascript/diff.js	2020-06-04 19:43:36 +0000
+++ loggerhead/static/javascript/diff.js	2020-09-09 16:46:30 +0000
@@ -109,7 +109,7 @@
   var diffs = $('.diff');
   if (diffs == null) return;
   diffs.each(
-    function(item, i)
+    function(i, item)
     {
       var collapsable = item.collapsable;
       if(action == 'close')