Merge ~twom/launchpad:oci-file-upload-deduplication into launchpad:master
Proposed by
Tom Wardill
Status: | Merged |
---|---|
Approved by: | Tom Wardill |
Approved revision: | 296522e8a4ccb0dc96c6fa206f56f9c4663521df |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~twom/launchpad:oci-file-upload-deduplication |
Merge into: | launchpad:master |
Diff against target: |
277 lines (+144/-4) 8 files modified
lib/lp/archiveuploader/ocirecipeupload.py (+12/-0) lib/lp/archiveuploader/tests/test_ocirecipeupload.py (+28/-0) lib/lp/oci/configure.zcml (+12/-0) lib/lp/oci/interfaces/ocirecipebuild.py (+8/-0) lib/lp/oci/model/ocirecipebuild.py (+11/-0) lib/lp/oci/model/ocirecipebuildbehaviour.py (+11/-4) lib/lp/oci/tests/test_ocirecipebuild.py (+27/-0) lib/lp/oci/tests/test_ocirecipebuildbehaviour.py (+35/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson (community) | Approve | ||
Ioana Lasc (community) | Approve | ||
Thiago F. Pappacena (community) | Approve | ||
Review via email: mp+383859@code.launchpad.net |
Commit message
Reuse existing image layers in new uploads
Description of the change
Rather than uploading each layer for each image to the librarian, reuse any that are existing.
This could introduce a race condition with garbage collection, but as we don't currently have any, it's safe for now, but should be considered in the design for garbo.
To post a comment you must log in.
Looks good!