Merge lp:~tplavcic/percona-server/bug1174779-5.5 into lp:percona-server/5.5

Proposed by Tomislav Plavcic
Status: Merged
Approved by: Laurynas Biveinis
Approved revision: no longer in the source branch.
Merged at revision: 648
Proposed branch: lp:~tplavcic/percona-server/bug1174779-5.5
Merge into: lp:percona-server/5.5
Diff against target: 93 lines (+20/-7) (has conflicts)
4 files modified
Makefile-ps (+2/-2)
UDF/configure.ac (+1/-1)
build-ps/build-binary.sh (+14/-1)
build-ps/percona-server.spec (+3/-3)
Text conflict in build-ps/build-binary.sh
To merge this branch: bzr merge lp:~tplavcic/percona-server/bug1174779-5.5
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Approve
Review via email: mp+213229@code.launchpad.net

This proposal supersedes a proposal from 2014-03-12.

Description of the change

Replaced MaatKit with Percona Toolkit
Fixed build flags

Discussed this with Laurynas over mail and it seems like I've forgot to resubmit MP.
Param build for 5.5 was:
https://code.launchpad.net/~tplavcic/percona-server/bug1174779-5.5/+merge/210706

To post a comment you must log in.
Revision history for this message
Tomislav Plavcic (tplavcic) wrote : Posted in a previous version of this proposal

Made another proposal, just not sure I did it right so please check my workflow.

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote : Posted in a previous version of this proposal

It is not an upmerge from 5.1. If it were, the output below would be empty, and bzr merge ../bug1174779-5.1 would be a no-op.

Throughout all versions no need to link bug 1266387, as it's a duplicate of bug 1174779.

bug1174779-5.5$ bzr missing --theirs-only ../bug1174779-5.1/
You are missing 2 revisions:
------------------------------------------------------------
revno: 597 [merge]
committer: Tomislav Plavcic <email address hidden>
branch nick: 5.1
timestamp: Fri 2014-03-07 00:03:40 +0100
message:
  Merged with trunk
------------------------------------------------------------
revno: 596
committer: Tomislav Plavcic <email address hidden>
branch nick: 5.1
timestamp: Fri 2014-03-07 00:01:16 +0100
message:
  Replaced MaatKit with Percona Toolkit
  Updated compilation flags

review: Needs Fixing
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Makefile-ps'
--- Makefile-ps 2014-03-25 13:05:17 +0000
+++ Makefile-ps 2014-03-28 10:48:37 +0000
@@ -20,7 +20,7 @@
20REVS = $(shell bzr log | grep rev | head -1 )20REVS = $(shell bzr log | grep rev | head -1 )
21REV = $(word 2, $(REVS) )21REV = $(word 2, $(REVS) )
2222
23all: maatkit-udf23all: pt-udf
24 @echo ""24 @echo ""
25 @echo "Percona Server source code is ready"25 @echo "Percona Server source code is ready"
26 @echo "Now change directory to $(PERCONA_SERVER) define variables as show below"26 @echo "Now change directory to $(PERCONA_SERVER) define variables as show below"
@@ -32,7 +32,7 @@
32 @echo "and run cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -DBUILD_CONFIG=mysql_release -DFEATURE_SET=community -DWITH_EMBEDDED_SERVER=OFF && make all install"32 @echo "and run cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -DBUILD_CONFIG=mysql_release -DFEATURE_SET=community -DWITH_EMBEDDED_SERVER=OFF && make all install"
33 @echo ""33 @echo ""
3434
35maatkit-udf:35pt-udf:
36 cd UDF && autoreconf --install36 cd UDF && autoreconf --install
3737
38configure: all38configure: all
3939
=== modified file 'UDF/configure.ac'
--- UDF/configure.ac 2013-12-20 02:58:23 +0000
+++ UDF/configure.ac 2014-03-28 10:48:37 +0000
@@ -1,4 +1,4 @@
1AC_INIT([maatkit-udf], [0.1], [http://code.google.com/p/maatkit/issues/list])1AC_INIT([pt-udf], [0.1], [https://bugs.launchpad.net/percona-toolkit])
2AM_INIT_AUTOMAKE([foreign -Wall -Wno-extra-portability foreign])2AM_INIT_AUTOMAKE([foreign -Wall -Wno-extra-portability foreign])
3AC_CONFIG_MACRO_DIR([m4])3AC_CONFIG_MACRO_DIR([m4])
4LT INIT4LT INIT
55
=== modified file 'build-ps/build-binary.sh'
--- build-ps/build-binary.sh 2014-02-19 12:33:29 +0000
+++ build-ps/build-binary.sh 2014-03-28 10:48:37 +0000
@@ -153,6 +153,7 @@
153153
154# Compilation flags154# Compilation flags
155export CC=${CC:-gcc}155export CC=${CC:-gcc}
156<<<<<<< TREE
156export CXX=${CXX:-g++}157export CXX=${CXX:-g++}
157#158#
158if [ -n "$(which rpm)" ]; then159if [ -n "$(which rpm)" ]; then
@@ -164,8 +165,20 @@
164export CFLAGS="${COMMON_FLAGS} -static-libgcc -DPERCONA_INNODB_VERSION=$PERCONA_SERVER_VERSION"165export CFLAGS="${COMMON_FLAGS} -static-libgcc -DPERCONA_INNODB_VERSION=$PERCONA_SERVER_VERSION"
165export CXXFLAGS="${COMMON_FLAGS} -DPERCONA_INNODB_VERSION=$PERCONA_SERVER_VERSION"166export CXXFLAGS="${COMMON_FLAGS} -DPERCONA_INNODB_VERSION=$PERCONA_SERVER_VERSION"
166#167#
168=======
169export CXX=${CXX:-g++}
170
171#
172if [ -n "$(which rpm)" ]; then
173 export COMMON_FLAGS=$(rpm --eval %optflags | sed -e "s|march=i386|march=i686|g")
174fi
175#
176export CFLAGS="${COMMON_FLAGS} -DPERCONA_INNODB_VERSION=$PERCONA_SERVER_VERSION"
177export CXXFLAGS="${COMMON_FLAGS} -DPERCONA_INNODB_VERSION=$PERCONA_SERVER_VERSION"
178#
179>>>>>>> MERGE-SOURCE
167export MAKE_JFLAG="${MAKE_JFLAG:--j$PROCESSORS}"180export MAKE_JFLAG="${MAKE_JFLAG:--j$PROCESSORS}"
168181#
169# Create a temporary working directory182# Create a temporary working directory
170INSTALLDIR="$(cd "$WORKDIR" && TMPDIR="$WORKDIR_ABS" mktemp -d percona-build.XXXXXX)"183INSTALLDIR="$(cd "$WORKDIR" && TMPDIR="$WORKDIR_ABS" mktemp -d percona-build.XXXXXX)"
171INSTALLDIR="$WORKDIR_ABS/$INSTALLDIR" # Make it absolute184INSTALLDIR="$WORKDIR_ABS/$INSTALLDIR" # Make it absolute
172185
=== modified file 'build-ps/percona-server.spec'
--- build-ps/percona-server.spec 2014-03-25 13:05:17 +0000
+++ build-ps/percona-server.spec 2014-03-28 10:48:37 +0000
@@ -818,12 +818,12 @@
818 fi818 fi
819fi819fi
820820
821echo "Percona Server is distributed with several useful UDF (User Defined Function) from Maatkit."821echo "Percona Server is distributed with several useful UDF (User Defined Function) from Percona Toolkit."
822echo "Run the following commands to create these functions:"822echo "Run the following commands to create these functions:"
823echo "mysql -e \"CREATE FUNCTION fnv1a_64 RETURNS INTEGER SONAME 'libfnv1a_udf.so'\""823echo "mysql -e \"CREATE FUNCTION fnv1a_64 RETURNS INTEGER SONAME 'libfnv1a_udf.so'\""
824echo "mysql -e \"CREATE FUNCTION fnv_64 RETURNS INTEGER SONAME 'libfnv_udf.so'\""824echo "mysql -e \"CREATE FUNCTION fnv_64 RETURNS INTEGER SONAME 'libfnv_udf.so'\""
825echo "mysql -e \"CREATE FUNCTION murmur_hash RETURNS INTEGER SONAME 'libmurmur_udf.so'\""825echo "mysql -e \"CREATE FUNCTION murmur_hash RETURNS INTEGER SONAME 'libmurmur_udf.so'\""
826echo "See http://code.google.com/p/maatkit/source/browse/trunk/udf for more details"826echo "See http://www.percona.com/doc/percona-server/5.5/management/udf_percona_toolkit.html for more details"
827827
828# Collect an upgrade history ...828# Collect an upgrade history ...
829echo "Upgrade/install finished at `date`" >> $STATUS_FILE829echo "Upgrade/install finished at `date`" >> $STATUS_FILE
@@ -1120,7 +1120,7 @@
1120%{_libdir}/mysql/libhsclient.a1120%{_libdir}/mysql/libhsclient.a
1121%{_libdir}/libhsclient.la1121%{_libdir}/libhsclient.la
11221122
1123# Maatkit UDF libs1123# Percona Toolkit UDF libs
1124%{_libdir}/mysql/plugin/libfnv1a_udf.a1124%{_libdir}/mysql/plugin/libfnv1a_udf.a
1125%{_libdir}/mysql/plugin/libfnv1a_udf.la1125%{_libdir}/mysql/plugin/libfnv1a_udf.la
1126%{_libdir}/mysql/plugin/libfnv_udf.a1126%{_libdir}/mysql/plugin/libfnv_udf.a

Subscribers

People subscribed via source and target branches