Merge lp:~tintou/slingshot/fix_rtl into lp:~elementary-pantheon/slingshot/trunk

[Corentin Noël]

Fixes RTL positionning

Fixes RTL positionning

[lp:~tintou/slingshot/fix_rtl]

451. By Launchpad Translations on behalf of elementary-pantheon on 2014-09-02

Launchpad automatic translations update.

452. By Launchpad Translations on behalf of elementary-pantheon on 2014-09-07

Launchpad automatic translations update.

[Tom Beckmann (tombeckmann)]

I think this may have problems with multimonitor. You should probably grab the width of the monitor and subtract the width of the window to make sure it won't overlap.

review: Needs Fixing

[lp:~tintou/slingshot/fix_rtl]

453. By Launchpad Translations on behalf of elementary-pantheon on 2014-09-25

Launchpad automatic translations update.

454. By Launchpad Translations on behalf of elementary-pantheon on 2014-10-02

Launchpad automatic translations update.

455. By spautz-julien on 2014-10-05

Centralize and clean up magic numbers of dimensions, padding, spacing, etc. Also fixes bug #1016154.

456. By Djax on 2014-10-05

Search generic name (lp:1347956)

457. By Cody Garver on 2014-10-05

No longer whitelist ibus-setup.desktop. It's bloody frightful. Whatever feature is needed from here should be added to lp:switchboard-plug-keyboard or something.

[Corentin Noël (tintou)]

@Tom: okay, fixed it
The popover arrow is not pointing the "Applications" label anymore in RTL because of this change but the Granite PopOver widget is missing any repointing function. So it's still better than what is in trunk

[lp:~tintou/slingshot/fix_rtl]

458. By Launchpad Translations on behalf of elementary-pantheon on 2014-10-12

Launchpad automatic translations update.

459. By Launchpad Translations on behalf of elementary-pantheon on 2014-10-13

Launchpad automatic translations update.

460. By Danielle Foré on 2014-10-14

no ellipsis

461. By Corentin Noël on 2014-10-14

Fixed mispositionning with RTL languages.

462. By Corentin Noël on 2014-10-14

Replaced Screen with Monitor.

463. By Corentin Noël on 2014-10-14

Merge two lines.

464. By Corentin Noël on 2014-10-14

get existing values.

[Tom Beckmann (tombeckmann)]

Looks great!

review: Approve

=== modified file 'src/SlingshotView.vala'
--- src/SlingshotView.vala	2014-10-14 01:30:37 +0000
+++ src/SlingshotView.vala	2014-10-14 18:28:04 +0000
@@ -364,6 +364,10 @@
                 reposition (false);
             });
 
+            get_style_context ().notify["direction"].connect (() => {
+                reposition (false);
+            });
+
             // check for change in gala settings
             Slingshot.settings.gala_settings.changed.connect (gala_settings_changed);
             gala_settings_changed ();
@@ -381,7 +385,6 @@
         }
 
         private void reposition (bool show=true) {
-
             debug("Repositioning");
 
             Gdk.Rectangle monitor_dimensions, app_launcher_pos;
@@ -391,6 +394,11 @@
                                                   width = 100,
                                                   height = 30
                                                  };
+
+            if (get_style_context ().direction == Gtk.TextDirection.RTL) {
+                app_launcher_pos.x += monitor_dimensions.width - this.get_window ().get_width ();
+            }
+
             move_to_rect (app_launcher_pos, show);
         }