Merge lp:~tintou/slingshot/fix-layout into lp:~elementary-pantheon/slingshot/trunk
Proposed by
Corentin Noël
Status: | Merged | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Approved by: | Corentin Noël | ||||||||||||||||
Approved revision: | 465 | ||||||||||||||||
Merged at revision: | 466 | ||||||||||||||||
Proposed branch: | lp:~tintou/slingshot/fix-layout | ||||||||||||||||
Merge into: | lp:~elementary-pantheon/slingshot/trunk | ||||||||||||||||
Diff against target: |
368 lines (+76/-98) 6 files modified
src/SlingshotView.vala (+1/-7) src/Utils.vala (+0/-9) src/Widgets/AppEntry.vala (+29/-29) src/Widgets/CategoryView.vala (+29/-43) src/Widgets/Grid.vala (+13/-5) src/Widgets/Sidebar.vala (+4/-5) |
||||||||||||||||
To merge this branch: | bzr merge lp:~tintou/slingshot/fix-layout | ||||||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tom Beckmann (community) | codestyle & code | Approve | |
Danielle Foré | ux | Approve | |
elementary Pantheon team | code | Pending | |
Review via email: mp+238506@code.launchpad.net |
Commit message
Adapt to category bar size.
Description of the change
* Category layout now autoadapts if the sidebar is larger than expected
* Removed Gtk.Layout + set_size_request in favor of get_preferred_
* Aligned AppItems with two lines support
To post a comment you must log in.
Looks good to me. Having two lines available for descriptions is a nice improvement. I don't see any distortions/ regressions in regards to alignment. UX Approve :)