Merge lp:~timo-jyrinki/qtvideo-node/port_to_qt56 into lp:qtvideo-node

Proposed by Timo Jyrinki
Status: Merged
Approved by: Jim Hodapp
Approved revision: 68
Merged at revision: 70
Proposed branch: lp:~timo-jyrinki/qtvideo-node/port_to_qt56
Merge into: lp:qtvideo-node
Diff against target: 71 lines (+23/-0)
4 files modified
src/qsgvideonode_p.cpp (+4/-0)
src/qsgvideonode_p.h (+13/-0)
src/shadervideonodeplugin.cpp (+5/-0)
src/shadervideonodeplugin.h (+1/-0)
To merge this branch: bzr merge lp:~timo-jyrinki/qtvideo-node/port_to_qt56
Reviewer Review Type Date Requested Status
Jim Hodapp (community) code Approve
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+292369@code.launchpad.net

Commit message

Port to Qt 5.6.

To post a comment you must log in.
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Seems to fix the issue for me.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/qsgvideonode_p.cpp'
--- src/qsgvideonode_p.cpp 2015-10-08 07:10:45 +0000
+++ src/qsgvideonode_p.cpp 2016-04-20 11:50:37 +0000
@@ -118,4 +118,8 @@
118 markDirty(DirtyGeometry);118 markDirty(DirtyGeometry);
119}119}
120120
121QSGVideoNodeFactoryInterface::~QSGVideoNodeFactoryInterface()
122{
123}
124
121QT_END_NAMESPACE125QT_END_NAMESPACE
122126
=== modified file 'src/qsgvideonode_p.h'
--- src/qsgvideonode_p.h 2015-10-08 07:10:45 +0000
+++ src/qsgvideonode_p.h 2016-04-20 11:50:37 +0000
@@ -34,6 +34,17 @@
34#ifndef QSGVIDEONODE_P_H34#ifndef QSGVIDEONODE_P_H
35#define QSGVIDEONODE_P_H35#define QSGVIDEONODE_P_H
3636
37//
38// W A R N I N G
39// -------------
40//
41// This file is not part of the Qt API. It exists purely as an
42// implementation detail. This header file may change from version to
43// version without notice, or even be removed.
44//
45// We mean it.
46//
47
37#include <QtQuick/qsgnode.h>48#include <QtQuick/qsgnode.h>
38#include <private/qtmultimediaquickdefs_p.h>49#include <private/qtmultimediaquickdefs_p.h>
3950
@@ -70,6 +81,8 @@
70class Q_MULTIMEDIAQUICK_EXPORT QSGVideoNodeFactoryInterface81class Q_MULTIMEDIAQUICK_EXPORT QSGVideoNodeFactoryInterface
71{82{
72public:83public:
84 virtual ~QSGVideoNodeFactoryInterface();
85
73 virtual QList<QVideoFrame::PixelFormat> supportedPixelFormats(QAbstractVideoBuffer::HandleType handleType) const = 0;86 virtual QList<QVideoFrame::PixelFormat> supportedPixelFormats(QAbstractVideoBuffer::HandleType handleType) const = 0;
74 virtual QSGVideoNode *createNode(const QVideoSurfaceFormat &format) = 0;87 virtual QSGVideoNode *createNode(const QVideoSurfaceFormat &format) = 0;
75};88};
7689
=== modified file 'src/shadervideonodeplugin.cpp'
--- src/shadervideonodeplugin.cpp 2013-09-10 13:28:07 +0000
+++ src/shadervideonodeplugin.cpp 2016-04-20 11:50:37 +0000
@@ -19,6 +19,11 @@
1919
20#include <QtCore/qdebug.h>20#include <QtCore/qdebug.h>
2121
22ShaderVideoNodePlugin::~ShaderVideoNodePlugin()
23{
24}
25
26
22QList<QVideoFrame::PixelFormat> ShaderVideoNodePlugin::supportedPixelFormats(27QList<QVideoFrame::PixelFormat> ShaderVideoNodePlugin::supportedPixelFormats(
23 QAbstractVideoBuffer::HandleType handleType) const28 QAbstractVideoBuffer::HandleType handleType) const
24{29{
2530
=== modified file 'src/shadervideonodeplugin.h'
--- src/shadervideonodeplugin.h 2015-10-08 07:10:45 +0000
+++ src/shadervideonodeplugin.h 2016-04-20 11:50:37 +0000
@@ -27,6 +27,7 @@
27 Q_PLUGIN_METADATA(IID "org.qt-project.qt.sgvideonodefactory/5.2" FILE "shadervideonode.json")27 Q_PLUGIN_METADATA(IID "org.qt-project.qt.sgvideonodefactory/5.2" FILE "shadervideonode.json")
2828
29public:29public:
30 ~ShaderVideoNodePlugin();
30 QList<QVideoFrame::PixelFormat> supportedPixelFormats(QAbstractVideoBuffer::HandleType handleType) const;31 QList<QVideoFrame::PixelFormat> supportedPixelFormats(QAbstractVideoBuffer::HandleType handleType) const;
31 QSGVideoNode *createNode(const QVideoSurfaceFormat &format);32 QSGVideoNode *createNode(const QVideoSurfaceFormat &format);
32};33};

Subscribers

People subscribed via source and target branches