Merge lp:~timo-jyrinki/dropping-letters/drop_audiorole_usage into lp:dropping-letters

Proposed by Timo Jyrinki
Status: Merged
Approved by: Timo Jyrinki
Approved revision: 69
Merged at revision: 69
Proposed branch: lp:~timo-jyrinki/dropping-letters/drop_audiorole_usage
Merge into: lp:dropping-letters
Diff against target: 33 lines (+0/-4)
1 file modified
dropping-letters.qml (+0/-4)
To merge this branch: bzr merge lp:~timo-jyrinki/dropping-letters/drop_audiorole_usage
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Needs Fixing
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Jim Hodapp (community) code Approve
Dropping Letters developers Pending
Review via email: mp+275150@code.launchpad.net

Commit message

Drop audioRole usage as it shouldn't be used in this use case

To post a comment you must log in.
Revision history for this message
Jim Hodapp (jhodapp) wrote :

Looks good to me.

review: Approve (code)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/dropping-letters-autolanding/1/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/379/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'dropping-letters.qml'
--- dropping-letters.qml 2014-09-26 22:56:07 +0000
+++ dropping-letters.qml 2015-10-21 09:28:20 +0000
@@ -331,21 +331,18 @@
331 id: click331 id: click
332 source: "407__tictacshutup__click-1-off-click.ogg"332 source: "407__tictacshutup__click-1-off-click.ogg"
333 autoLoad: volume.supportsMedia333 autoLoad: volume.supportsMedia
334 audioRole: MediaPlayer.alert
335 }334 }
336335
337 Audio {336 Audio {
338 id: success337 id: success
339 source: "80921__justinbw__buttonchime02up.ogg"338 source: "80921__justinbw__buttonchime02up.ogg"
340 autoLoad: volume.supportsMedia339 autoLoad: volume.supportsMedia
341 audioRole: MediaPlayer.alert
342 }340 }
343341
344 Audio {342 Audio {
345 id: failure343 id: failure
346 source: "106727__kantouth__cartoon-bing-low.ogg"344 source: "106727__kantouth__cartoon-bing-low.ogg"
347 autoLoad: volume.supportsMedia345 autoLoad: volume.supportsMedia
348 audioRole: MediaPlayer.alert
349 }346 }
350347
351 Audio {348 Audio {
@@ -355,7 +352,6 @@
355 onStopped: {352 onStopped: {
356 flipable.flipped = false353 flipable.flipped = false
357 }354 }
358 audioRole: MediaPlayer.alert
359 }355 }
360356
361 Rectangle {357 Rectangle {

Subscribers

People subscribed via source and target branches