Merge lp:~tiagosh/telepathy-ofono/rtm-14.09-fix-1398525 into lp:telepathy-ofono/rtm-14.09

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Bill Filler
Approved revision: 104
Merged at revision: 104
Proposed branch: lp:~tiagosh/telepathy-ofono/rtm-14.09-fix-1398525
Merge into: lp:telepathy-ofono/rtm-14.09
Diff against target: 61 lines (+18/-6)
2 files modified
connection.cpp (+4/-3)
powerdaudiomodemediator.cpp (+14/-3)
To merge this branch: bzr merge lp:~tiagosh/telepathy-ofono/rtm-14.09-fix-1398525
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
Review via email: mp+244623@code.launchpad.net

Commit message

Disable proximity sensor also when using a wired headset.

Description of the change

Disable proximity sensor also when using a wired headset.

To post a comment you must log in.
Revision history for this message
Bill Filler (bfiller) wrote :

tested, approved

review: Approve
105. By Tiago Salem Herrmann

power the screen on before disabling the proximity handling

Revision history for this message
Bill Filler (bfiller) wrote :

re-tested, works with updated fix

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'connection.cpp'
--- connection.cpp 2014-10-15 12:32:16 +0000
+++ connection.cpp 2014-12-15 19:42:30 +0000
@@ -1005,9 +1005,10 @@
1005{1005{
1006 qDebug("PulseAudio audio mode changed: 0x%x", mode);1006 qDebug("PulseAudio audio mode changed: 0x%x", mode);
10071007
1008 if ((mode == AudioModeEarpiece && mActiveAudioOutput != "default") ||1008 if (mode == AudioModeEarpiece && mActiveAudioOutput != "earpiece") {
1009 (mode == AudioModeWiredHeadset && mActiveAudioOutput != "default")) {1009 setActiveAudioOutput("earpiece");
1010 setActiveAudioOutput("default");1010 } else if (mode == AudioModeWiredHeadset && mActiveAudioOutput != "wired_headset") {
1011 setActiveAudioOutput("wired_headset");
1011 } else if (mode == AudioModeSpeaker && mActiveAudioOutput != "speaker") {1012 } else if (mode == AudioModeSpeaker && mActiveAudioOutput != "speaker") {
1012 setActiveAudioOutput("speaker");1013 setActiveAudioOutput("speaker");
1013 } else if (mode == AudioModeBluetooth && mActiveAudioOutput != "bluetooth") {1014 } else if (mode == AudioModeBluetooth && mActiveAudioOutput != "bluetooth") {
10141015
=== modified file 'powerdaudiomodemediator.cpp'
--- powerdaudiomodemediator.cpp 2014-09-30 17:25:02 +0000
+++ powerdaudiomodemediator.cpp 2014-12-15 19:42:30 +0000
@@ -16,6 +16,7 @@
16 * Authors: Andreas Pokorny <andreas.pokorny@canonical.com>16 * Authors: Andreas Pokorny <andreas.pokorny@canonical.com>
17 */17 */
1818
19#include <QDBusInterface>
19#include "powerdaudiomodemediator.h"20#include "powerdaudiomodemediator.h"
2021
21PowerDAudioModeMediator::PowerDAudioModeMediator(PowerD &powerd)22PowerDAudioModeMediator::PowerDAudioModeMediator(PowerD &powerd)
@@ -25,7 +26,7 @@
2526
26void PowerDAudioModeMediator::audioModeChanged(const QString &mode)27void PowerDAudioModeMediator::audioModeChanged(const QString &mode)
27{28{
28 bool enableProximity = !(mode == "speaker" || mode == "bluetooth");29 bool enableProximity = !(mode == "speaker" || mode == "bluetooth" || mode == "wired_headset");
2930
30 if (mProximityEnabled != enableProximity)31 if (mProximityEnabled != enableProximity)
31 {32 {
@@ -36,10 +37,20 @@
3637
37void PowerDAudioModeMediator::apply() const38void PowerDAudioModeMediator::apply() const
38{39{
39 if (mProximityEnabled)40 if (mProximityEnabled) {
40 powerd.enableProximityHandling();41 powerd.enableProximityHandling();
41 else42 } else {
43 // we need to power the screen on before disabling the proximity handling
44 QDBusInterface unityIface("com.canonical.Unity.Screen",
45 "/com/canonical/Unity/Screen",
46 "com.canonical.Unity.Screen",
47 QDBusConnection::systemBus());
48 QList<QVariant> args;
49 args.append("on");
50 args.append(3);
51 unityIface.callWithArgumentList(QDBus::NoBlock, "setScreenPowerMode", args);
42 powerd.disableProximityHandling();52 powerd.disableProximityHandling();
53 }
43}54}
4455
45void PowerDAudioModeMediator::audioOutputClosed()56void PowerDAudioModeMediator::audioOutputClosed()

Subscribers

People subscribed via source and target branches