messaging-app

Merge lp:~tiagosh/messaging-app/fix-1227356 into lp:messaging-app

  1. fix-1227356
  2. Merge into trunk
Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 37
Merged at revision: 38
Proposed branch: lp:~tiagosh/messaging-app/fix-1227356
Merge into: lp:messaging-app
Diff against target: 23 lines (+1/-1)
2 files modified
src/qml/Messages.qml (+1/-0)
tests/autopilot/messaging_app/tests/test_messaging.py (+0/-1)
To merge this branch: bzr merge lp:~tiagosh/messaging-app/fix-1227356
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+187114@code.launchpad.net

Commit message

Focus phone number entry when composing a new message.

Description of the change

Focus phone number entry when composing a new message.

To post a comment you must log in.
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Can you please add an autopilot testcase for this change?

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:36
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/56/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/3881
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/1423
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-saucy-amd64-ci/56
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-saucy-armhf-ci/56
        deb: http://jenkins.qa.ubuntu.com/job/messaging-app-saucy-armhf-ci/56/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-saucy-i386-ci/56
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/216
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3907
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3907/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1425
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1425/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1201
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1212

Click here to trigger a rebuild:
http://s-jenkins:8080/job/messaging-app-ci/56/rebuild

review: Approve (continuous-integration)
lp:~tiagosh/messaging-app/fix-1227356 updated
37. By Tiago Salem Herrmann

do not click anymore. the field will be focused automatically from now one.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:37
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/57/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/3948
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/1539
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-saucy-amd64-ci/57
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-saucy-armhf-ci/57
        deb: http://jenkins.qa.ubuntu.com/job/messaging-app-saucy-armhf-ci/57/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-saucy-i386-ci/57
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/276
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/4022
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/4022/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1541
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1541/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1299
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1310

Click here to trigger a rebuild:
http://s-jenkins:8080/job/messaging-app-ci/57/rebuild

review: Approve (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good and works as expected!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/qml/Messages.qml'
--- src/qml/Messages.qml 2013-09-23 22:25:31 +0000
+++ src/qml/Messages.qml 2013-09-24 18:23:41 +0000
@@ -181,6 +181,7 @@
181 clip: true181 clip: true
182 height: (number === "" && threadId == "") ? units.gu(7) : 0182 height: (number === "" && threadId == "") ? units.gu(7) : 0
183 focus: true183 focus: true
184 Component.onCompleted: number === "" && newPhoneNumberField.forceActiveFocus()
184185
185 Label {186 Label {
186 id: labelTo187 id: labelTo
187188
=== modified file 'tests/autopilot/messaging_app/tests/test_messaging.py'
--- tests/autopilot/messaging_app/tests/test_messaging.py 2013-09-04 16:57:04 +0000
+++ tests/autopilot/messaging_app/tests/test_messaging.py 2013-09-24 18:23:41 +0000
@@ -33,7 +33,6 @@
33 self.assertThat(self.main_view.get_pagestack().depth, Eventually(Equals(2)))33 self.assertThat(self.main_view.get_pagestack().depth, Eventually(Equals(2)))
34 self.assertThat(self.main_view.get_messages_page().visible, Eventually(Equals(True)))34 self.assertThat(self.main_view.get_messages_page().visible, Eventually(Equals(True)))
35 text_entry = self.main_view.get_newmessage_textfield()35 text_entry = self.main_view.get_newmessage_textfield()
36 self.pointing_device.click_object(text_entry)
37 text_entry.activeFocus.wait_for(True)36 text_entry.activeFocus.wait_for(True)
38 self.keyboard.type("123")37 self.keyboard.type("123")
39 self.assertThat(text_entry.text, Eventually(Equals("123")))38 self.assertThat(text_entry.text, Eventually(Equals("123")))

Subscribers

People subscribed via source and target branches