Merge lp:~thomir-deactivatedaccount/charm-haproxy/make-config-less-insane into lp:~ubuntuone-pqm-team/charm-haproxy/snap-store

Proposed by Thomi Richards
Status: Merged
Merged at revision: 112
Proposed branch: lp:~thomir-deactivatedaccount/charm-haproxy/make-config-less-insane
Merge into: lp:~ubuntuone-pqm-team/charm-haproxy/snap-store
Diff against target: 20 lines (+3/-3)
1 file modified
hooks/hooks.py (+3/-3)
To merge this branch: bzr merge lp:~thomir-deactivatedaccount/charm-haproxy/make-config-less-insane
Reviewer Review Type Date Requested Status
William Grant code Approve
haproxy-team Pending
Review via email: mp+328011@code.launchpad.net

This proposal supersedes a proposal from 2017-07-25.

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'hooks/hooks.py'
--- hooks/hooks.py 2017-07-25 07:08:49 +0000
+++ hooks/hooks.py 2017-07-25 07:57:42 +0000
@@ -349,13 +349,13 @@
349 be_options.append(o)349 be_options.append(o)
350350
351 # Filter provided service options into frontend-only and backend-only.351 # Filter provided service options into frontend-only and backend-only.
352 # XXX: The '{FE}' and '{BE}' feature is a local patch in this version352 # XXX: The '<FE>' and '<BE>' feature is a local patch in this version
353 # of the charm, and is not present in the upstream charm.353 # of the charm, and is not present in the upstream charm.
354 for option in service_options:354 for option in service_options:
355 option = option.strip()355 option = option.strip()
356 if option.startswith('{FE}'):356 if option.startswith('<FE>'):
357 fe_options.append(option[4:].strip())357 fe_options.append(option[4:].strip())
358 elif option.startswith('{BE}'):358 elif option.startswith('<BE>'):
359 be_options.append(option[4:].strip())359 be_options.append(option[4:].strip())
360 else:360 else:
361 if any(map(option.startswith, frontend_only_options)):361 if any(map(option.startswith, frontend_only_options)):

Subscribers

People subscribed via source and target branches

to all changes: