Merge lp:~thomas-voss/trust-store/lp-1596951 into lp:trust-store

Proposed by Thomas Voß
Status: Approved
Approved by: Thomas Voß
Approved revision: 159
Proposed branch: lp:~thomas-voss/trust-store/lp-1596951
Merge into: lp:trust-store
Diff against target: 58 lines (+14/-5)
2 files modified
po/trust-store.pot (+8/-4)
src/core/trust/daemon.cpp (+6/-1)
To merge this branch: bzr merge lp:~thomas-voss/trust-store/lp-1596951
Reviewer Review Type Date Requested Status
Simon Fels Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+298839@code.launchpad.net

Commit message

Special case for handling CameraService translations.

Description of the change

Special case for handling CameraService translations.

To post a comment you must log in.
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve

Unmerged revisions

159. By Thomas Voß

Special case for handling CameraService translations.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'po/trust-store.pot'
--- po/trust-store.pot 2016-01-12 20:04:43 +0000
+++ po/trust-store.pot 2016-06-30 21:35:42 +0000
@@ -8,7 +8,7 @@
8msgstr ""8msgstr ""
9"Project-Id-Version: trust-store\n"9"Project-Id-Version: trust-store\n"
10"Report-Msgid-Bugs-To: \n"10"Report-Msgid-Bugs-To: \n"
11"POT-Creation-Date: 2016-01-12 21:03+0100\n"11"POT-Creation-Date: 2016-06-30 23:33+0200\n"
12"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"12"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
13"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"13"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
14"Language-Team: LANGUAGE <LL@li.org>\n"14"Language-Team: LANGUAGE <LL@li.org>\n"
@@ -17,14 +17,18 @@
17"Content-Type: text/plain; charset=UTF-8\n"17"Content-Type: text/plain; charset=UTF-8\n"
18"Content-Transfer-Encoding: 8bit\n"18"Content-Transfer-Encoding: 8bit\n"
1919
20#: /home/tvoss/ubuntu/scratch/fix-1532870/src/core/trust/daemon.cpp:26620#: /home/tvoss/ubuntu/scratch/lp-1596951/src/core/trust/daemon.cpp:171
21msgid "is trying to access"21msgid "is trying to access"
22msgstr ""22msgstr ""
2323
24#: /home/tvoss/ubuntu/scratch/fix-1532870/src/core/trust/mir/prompt_main.qml:7824#: /home/tvoss/ubuntu/scratch/lp-1596951/src/core/trust/daemon.cpp:173
25msgid "CameraService"
26msgstr ""
27
28#: /home/tvoss/ubuntu/scratch/lp-1596951/src/core/trust/mir/prompt_main.qml:78
25msgid "Allow"29msgid "Allow"
26msgstr ""30msgstr ""
2731
28#: /home/tvoss/ubuntu/scratch/fix-1532870/src/core/trust/mir/prompt_main.qml:8332#: /home/tvoss/ubuntu/scratch/lp-1596951/src/core/trust/mir/prompt_main.qml:83
29msgid "Don’t Allow"33msgid "Don’t Allow"
30msgstr ""34msgstr ""
3135
=== modified file 'src/core/trust/daemon.cpp'
--- src/core/trust/daemon.cpp 2016-01-11 09:51:51 +0000
+++ src/core/trust/daemon.cpp 2016-06-30 21:35:42 +0000
@@ -168,6 +168,11 @@
168 "Missing endpoint specification for UnixDomainSocketRemoteAgent."168 "Missing endpoint specification for UnixDomainSocketRemoteAgent."
169 };169 };
170170
171 const auto default_description_pattern = core::trust::i18n::tr("is trying to access") + " " +
172 (service_name == "CameraService"
173 ? core::trust::i18n::tr("CameraService") // We have to special-case and mark CameraService to enable translations.
174 : service_name) + ".";
175
171 core::trust::remote::posix::Skeleton::Configuration config176 core::trust::remote::posix::Skeleton::Configuration config
172 {177 {
173 agent,178 agent,
@@ -177,7 +182,7 @@
177 core::trust::remote::helpers::aa_get_task_con_app_id_resolver(),182 core::trust::remote::helpers::aa_get_task_con_app_id_resolver(),
178 dict.count("description-pattern") > 0 ?183 dict.count("description-pattern") > 0 ?
179 dict.at("description-pattern") :184 dict.at("description-pattern") :
180 core::trust::i18n::tr("is trying to access") + " " + service_name + ".",185 default_description_pattern,
181 dict.count("verify-process-timestamp") > 0186 dict.count("verify-process-timestamp") > 0
182 };187 };
183188

Subscribers

People subscribed via source and target branches