Merge lp:~therp-nl/server-env-tools/7.0-my_OpenERP_is_not_unsupported into lp:~server-env-tools-core-editors/server-env-tools/7.0

[Stefan Rijnhart (Opener)]

[lp:~therp-nl/server-env-tools/7.0-my_OpenERP_is_not_unsupported]

56. By Stefan Rijnhart (Opener) on 2013-12-21

[FIX] Typo

[Sylvain LE GAL (GRAP) (sylvain-legal)]

Hi.

Thanks. LGTM.

review: Approve (code review, no test)

[Nicolas JEUDY (njeudy)]

Hi community,

I think we need to be more "impartial" in community branch. Some want to keep this feature and some not (i think).
Why not add a ir.config_parameter "disable_openerp_online" and set to True byr default ? If True, no panel if false, panel still here ?

What do you think ?

[Sylvain LE GAL (GRAP) (sylvain-legal)]

Hi Nicolas,

Yes I think that we need to be "impartial" as you said.
But this MP is OK for me. If you're using this module, so you're using branches (Git / LP) and you're not using online module management. because this is a the aim of 'disable_openerp_online' module.
So, people who use 'disable_openerp_online' are administrator and are "supporting" the installed software. It's normal for me that the banner is hidden.

You really think that there are people installing this module who want the banner ?

I don't think so, but maybe I'm wrong...

Depending of communinity opinion :
solution 1 : keep this MP as it ;
solution 2 : ir.config_parameter ;
solution 3 : a new module "shoot_that_banner" (or something like that) that do only that ;

Regards.

[Stefan Rijnhart (Opener) (stefan-opener)]

Agree with Sylvain here. This is a pretty 'militant' module in itself, trying to prevent OpenERP to phone home and stop it from pushing the OPW. I think everyone who installs this module knows what their doing and either has an OPW already or does not want to be reminded of not having one.

[Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903)]

review: Approve

[Nicolas JEUDY (njeudy)]

Ok you are right,

If an admin install this module, he want to disable all OpenERP online tricks.

review: Approve (code and test)

[Mario Arias (the-clone-master)]

+1 as it is now...

Works just as expected

review: Approve (code and test)

[Nhomar - Vauxoo (nhomar)]

For sure you will kill me with my comment but well I am goint to say (and you can be counter me may be).

Why not improve the message instead simply hide it.

- Formally I understand the main point "My implementations are "Supported by me"".
- But formally, It can help us to say our customers "Men, buy an enterprise licence can give some advantage, this and this and this....".

May be the module shoud change the direction of the link may be to the OCA site explaining the benefits of "support" the tool that you are using now, not simply Hide the message at once.

In our case, I have customers without Enterprise too, and I only said "Click on the X at the right and it will be hidden", if you want it hidden correctly you can "try" understand the benefits of support the OpenSource ecosystem and the editor, because everybody should win and the service offer from openerp is not a heresy, (which I being partner will be benefited by itself) and the ecosystem is health enought.

IMHO as community the first version of this module is "right" "Don't phone to home" but this one IMHO should not be supported by us as Official community it is politically incorrect, everybody should know who is behind the opensource tool is using, and the code itself is only verifying a number that don't have any risk in any implementation.

I don't want start a fight I just want to be able to put a middle point here, is more dangerous stop the marketing that openerp is doing, that simply say to our customers "This is the correct way".

I made a presentation about this at Community days 2012.

http://www.slideshare.net/nhomar/the-openerp-ecosystem-business-model

Thanks.

review: Abstain

[Sylvain LE GAL (GRAP) (sylvain-legal)]

Hi Nhomar. Thank for sharing your opinion.

I think your point of view is not ok for all the situations. You're talking about customers and you say "don't lie to them / Don't hide OpenERP SA importance to them". (or something like that if I correctly understand). It's respectable.
In my personnal case, I'm interested by this feature because I don't have any customers. I only work for my company that did the choice not to buy OPW for the moment. (The question is not here to know if it's a good or bad choice, it's a complex choice). ;-)
So, in my case pop-ups, banners,... are just annoying.

So, regarding to my comment https://code.launchpad.net/~therp-nl/server-env-tools/7.0-my_OpenERP_is_not_unsupported/+merge/199896/comments/464435, It seems that you're not agree with solution 1.
Do you agree with solution 2 or 3. Do you prefer one ?

Regards.

[Nicolas JEUDY (njeudy)]

Hi Nhomar, (and others)

I think in this module, it's ok to disable it.
Now, We should be able to add (if we need) such panel with our point of view or with the original one. But it should be an other module to add "community panel" because OPW does not support mods we are using in our install (community one).

So If we want to be clear, we have to say that even if you choose OPW, you will not be "protected" with some of community modules ...

As some other people, we decide to used OCB branch and lots of community modules, we want to have a way to quickly disable marketing tricks (and OpenERP SA should have create an option to do this I think). This module is the quick way to do this :)

Thanks,

[Stefan Rijnhart (Opener) (stefan-opener)]

Hi Nhomar,

Your point is a valid opinion, but the installation of this module in its old form already conflicted with it. By preventing the other forms of communication with OpenERP SA, this module already interfered with the interests of OpenERP SA, as all of those forms amounted to exposure of support contracts and OpenERP online accounts, and gathering marketing information. This MP does not change anything to the module in that respect.

Given the fact that this module is not forced upon anyone, and that it is completely agnostic to whether an OPW is bought, I fail to see the politically incorrectness. In fact, if this module is not the very first module that you ever install on your new database, you are going to see the OPW announcement anyway.

Your use case, of informing users without an OPW of its benefits without pinging OpenERP SA is out of scope for this module, but it can be easily crafted by your team in a separate module that depends on this one.

[Ronald Portier (Therp) (rportier1962)]

Approve. Code and test.

review: Approve

[Nhomar - Vauxoo (nhomar)]

What do you think, if we put this feature taking the option 3:

solution 3 : a new module "shoot_that_banner" (or something like that) that do only that ;

In this point it should be great middle point, It means, instead configure it (which make so complex programatically) the "COnfiguration " will be install - uninstall.

In this way personally i can be agreed seeing we have a lot of people agreed with valid points.

REgards.

[Stefan Rijnhart (Opener) (stefan-opener)]

That does not have my preference. Current MP fits the module name and purpose perfectly. Anything else would be horribly confusing and cumbersome.

[Ronald Portier (Therp) (rportier1962)]

+1.

Totally agree with Stefan.

Else, what next? A third module when OpenERP SA includes some more marketing stuff in code where it should have no place...?

I want one module to remove it all. Better if it had not been there in the first place.

[Stefan Rijnhart (Opener) (stefan-opener)]

BTW, I'm weighing in here that you are claiming a middle ground between you on the one side and 5 people who already approved this branch plus the submitter on the other.

[Nhomar - Vauxoo (nhomar)]

2013/12/23 Stefan Rijnhart (Therp) <email address hidden>

> That does not have my preference. Current MP fits the module name and
> purpose perfectly. Anything else would be horribly confusing and cumbersome.

Well as I said it doesn't (but it is my PoV), you can execute the MP (you
have 3 approvals already) and nothing happen, as you say we can simply
don't install it that's all.... but IMHO it is not the objective of mine
establish a dictatorial way to do things something like "Kick every single
marketing stuff I from OpenERP", because my friend remember, at the end of
the day, "they did +90% of the code in all your implementations", and with
this intent and MP and PoV what make us different from them if we using
them modules develop always the counter part that block the information and
links that can help them¿? whats the difference between this PoV and Them
(if you think them vision and tools are wrong).

Then, if our objective as community is kill all commercial intent from
OpenERP side I think the objective is wrong and it is not in our initial
vision I think.

BTW

Make the merge, the process was accomplished, no problem, side effects are
NOT measurable and them all are Subjective (until we can measure the
increase or decrease of something), continue this discussion with your
locked PoV is not possible.

But I personally can not "Approve" "this is why i marked it as "Abstain"
this __today__ is more dangerous than helpful for us as community and for
us as commercial ecosystem, brake all transparent commercial intent from
any side is not "at least" my objective.

Regards.

[Sylvain LE GAL (GRAP) (sylvain-legal)]

Hi.

So it seems that most people are not agree with "solution 3" and prefer the "solution 1".

If everybody is ok (except Nhomar, sorry), I propose to merge this proposition.

+++

[Cubic ERP (cubicerp)]

Hi Nhomar, only to clarify about your comment "... at the end of
the day, "they (OpenERP) did +90% of the code in all your implementations",...", only to verify for example check on web project how many code wrote by OpenERP less than 1Mb, and EXTERNAL LIBRARIES like to AJAX, JQuery, BackBone and others sum 3.4Mb.

Then apply your maths, and check on your project OpenERP only contribute less than 27%, without your own code.

Regards

[Nhomar - Vauxoo (nhomar)]

2014/1/21 Cubic ERP <email address hidden>

> Hi Nhomar, only to clarify about your comment "... at the end of
> the day, "they (OpenERP) did +90% of the code in all your
> implementations",...", only to verify for example check on web project how
> many code wrote by OpenERP less than 1Mb, and EXTERNAL LIBRARIES like to
> AJAX, JQuery, BackBone and others sum 3.4Mb.
>

Wrong comparition, IMHO this should be topic for other conversations, but I
left you some links.

http://www.ohloh.net/p/openerp
http://www.ohloh.net/p/jquery

AJAX IS NOT a software.

http://www.ohloh.net/p/backbone

http://www.ohloh.net/p/OTHERS.

Then, try wth other to run with them __only__ run the management of your
business, and your comparision is good.

Then take into account how much jquery libs, backbone and so on are used
and how they impact in the system.

With all this mixed you can make your statement more clear and not confused.

It means in 3 lines.

Download Openerp Load a module of maybe 3 month of work of 1 person,
"Manage thousand of dollar in business process".

Download Jquery "What you can do?"

do you got my point?

I don't want to be rude with you men but your comment is totally Out of
Scope in this MP for me it was closed several time ago.
--
--------------------
Saludos Cordiales

Nhomar G. Hernandez M.
[phone]
Skype: nhomar00
Web-Blog: http://geronimo.com.ve
Servicios IT: http://vauxoo.com
Linux-Counter: 467724
Correos:
<email address hidden>
<email address hidden>
twitter @nhomar

=== modified file 'disable_openerp_online/__openerp__.py'
--- disable_openerp_online/__openerp__.py	2013-08-14 07:48:23 +0000
+++ disable_openerp_online/__openerp__.py	2013-12-21 14:02:00 +0000
@@ -20,7 +20,7 @@
 ##############################################################################
 {
     "name" : "Remove openerp.com bindings",
-    "version" : "1.0",
+    "version" : "1.1",
     "author" : "Therp BV",
     "complexity": "normal",
     "description": """
@@ -30,6 +30,7 @@
 * update notifier code is deactivated and the function is overwritten
 * apps and updates menu items in settings are removed
 * help and account menu items in user menu are removed
+* prevent lookup of OPW for current database uuid and resulting 'unsupported' warning
     """,
     "category" : "",
     "depends" : [
@@ -41,6 +42,7 @@
         'data/ir_cron.xml',
     ],
     "js": [
+        'static/src/js/disable_openerp_online.js',
     ],
     "css": [
     ],

=== added directory 'disable_openerp_online/static/src/js'
=== added file 'disable_openerp_online/static/src/js/disable_openerp_online.js'
--- disable_openerp_online/static/src/js/disable_openerp_online.js	1970-01-01 00:00:00 +0000
+++ disable_openerp_online/static/src/js/disable_openerp_online.js	2013-12-21 14:02:00 +0000
@@ -0,0 +1,7 @@
+openerp.disable_openerp_online = function(instance) {
+    // Disabling the lookup of a valid OPW for the dbuuid,
+    // resulting in 'Your OpenERP is not supported'
+    instance.web.WebClient.include({
+        show_annoucement_bar: function() {}
+    });
+};