Merge lp:~therp-nl/ocb-web/lp1303829 into lp:ocb-web

Proposed by Holger Brunn (Therp)
Status: Rejected
Rejected by: Holger Brunn (Therp)
Proposed branch: lp:~therp-nl/ocb-web/lp1303829
Merge into: lp:ocb-web
Diff against target: 16 lines (+0/-2)
1 file modified
addons/web_kanban/static/src/js/kanban.js (+0/-2)
To merge this branch: bzr merge lp:~therp-nl/ocb-web/lp1303829
Reviewer Review Type Date Requested Status
OpenERP Community Backports Pending
Review via email: mp+214542@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

Unmerged revisions

4177. By Holger Brunn (Therp)

[FIX] don't mess with the dataset's ids

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'addons/web_kanban/static/src/js/kanban.js'
--- addons/web_kanban/static/src/js/kanban.js 2014-01-17 10:19:43 +0000
+++ addons/web_kanban/static/src/js/kanban.js 2014-04-07 14:09:23 +0000
@@ -637,12 +637,10 @@
637 },637 },
638 do_show_more: function(evt) {638 do_show_more: function(evt) {
639 var self = this;639 var self = this;
640 var ids = self.view.dataset.ids.splice(0);
641 return this.dataset.read_slice(this.view.fields_keys.concat(['__last_update']), {640 return this.dataset.read_slice(this.view.fields_keys.concat(['__last_update']), {
642 'limit': self.view.limit,641 'limit': self.view.limit,
643 'offset': self.dataset_offset += self.view.limit642 'offset': self.dataset_offset += self.view.limit
644 }).then(function(records) {643 }).then(function(records) {
645 self.view.dataset.ids = ids.concat(self.dataset.ids);
646 self.do_add_records(records);644 self.do_add_records(records);
647 self.compute_cards_auto_height();645 self.compute_cards_auto_height();
648 self.view.postprocess_m2m_tags();646 self.view.postprocess_m2m_tags();

Subscribers

People subscribed via source and target branches