Merge lp:~therp-nl/ocb-addons/6.1-lp1315367-task_work_timesheet_lines_False into lp:ocb-addons/6.1

Proposed by Stefan Rijnhart (Opener)
Status: Merged
Approved by: Holger Brunn (Therp)
Approved revision: no longer in the source branch.
Merged at revision: 6843
Proposed branch: lp:~therp-nl/ocb-addons/6.1-lp1315367-task_work_timesheet_lines_False
Merge into: lp:ocb-addons/6.1
Diff against target: 29 lines (+3/-3)
1 file modified
project_timesheet/project_timesheet.py (+3/-3)
To merge this branch: bzr merge lp:~therp-nl/ocb-addons/6.1-lp1315367-task_work_timesheet_lines_False
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) code review Approve
Pedro Manuel Baeza code review Approve
Raphaël Valyi - http://www.akretion.com Approve
Review via email: mp+218060@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Raphaël Valyi - http://www.akretion.com (rvalyi) wrote :

LGTM

review: Approve
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

LGTM (that parenthesis order...)

review: Approve (code review)
Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'project_timesheet/project_timesheet.py'
--- project_timesheet/project_timesheet.py 2013-09-10 15:12:35 +0000
+++ project_timesheet/project_timesheet.py 2014-05-02 12:36:24 +0000
@@ -85,7 +85,7 @@
85 if not context.get('no_analytic_entry',False):85 if not context.get('no_analytic_entry',False):
86 obj_task = task_obj.browse(cr, uid, vals['task_id'])86 obj_task = task_obj.browse(cr, uid, vals['task_id'])
87 result = self.get_user_related_details(cr, uid, vals.get('user_id', uid))87 result = self.get_user_related_details(cr, uid, vals.get('user_id', uid))
88 vals_line['name'] = '%s: %s' % (tools.ustr(obj_task.name), tools.ustr(vals['name']) or '/')88 vals_line['name'] = '%s: %s' % (tools.ustr(obj_task.name), tools.ustr(vals['name'] or '/'))
89 vals_line['user_id'] = vals['user_id']89 vals_line['user_id'] = vals['user_id']
90 vals_line['product_id'] = result['product_id']90 vals_line['product_id'] = result['product_id']
91 vals_line['date'] = vals['date'][:10]91 vals_line['date'] = vals['date'][:10]
@@ -139,7 +139,7 @@
139 continue139 continue
140 vals_line = {}140 vals_line = {}
141 if 'name' in vals:141 if 'name' in vals:
142 vals_line['name'] = '%s: %s' % (tools.ustr(task.task_id.name), tools.ustr(vals['name']) or '/')142 vals_line['name'] = '%s: %s' % (tools.ustr(task.task_id.name), tools.ustr(vals['name'] or '/'))
143 if 'user_id' in vals:143 if 'user_id' in vals:
144 vals_line['user_id'] = vals['user_id']144 vals_line['user_id'] = vals['user_id']
145 145
@@ -219,7 +219,7 @@
219 if vals.get('project_id',False):219 if vals.get('project_id',False):
220 vals_line['account_id'] = acc_id220 vals_line['account_id'] = acc_id
221 if vals.get('name',False):221 if vals.get('name',False):
222 vals_line['name'] = '%s: %s' % (tools.ustr(vals['name']), tools.ustr(task_work.name) or '/')222 vals_line['name'] = '%s: %s' % (tools.ustr(vals['name']), tools.ustr(task_work.name or '/'))
223 hr_anlytic_timesheet.write(cr, uid, [line_id], vals_line, {})223 hr_anlytic_timesheet.write(cr, uid, [line_id], vals_line, {})
224 return super(task,self).write(cr, uid, ids, vals, context)224 return super(task,self).write(cr, uid, ids, vals, context)
225225

Subscribers

People subscribed via source and target branches