Banking Addons

Merge lp:~therp-nl/banking-addons/6.1-fix_workflow_stop_string_value_evaluates_to_True into lp:banking-addons/6.1

  1. 6.1-fix_workflow_stop_string_value_evaluates_to_True
  2. Merge into 6.1
Proposed by Stefan Rijnhart (Opener)
Status: Merged
Merged at revision: 151
Proposed branch: lp:~therp-nl/banking-addons/6.1-fix_workflow_stop_string_value_evaluates_to_True
Merge into: lp:banking-addons/6.1
Diff against target: 12 lines (+1/-1)
1 file modified
account_direct_debit/workflow/account_payment.xml (+1/-1)
To merge this branch: bzr merge lp:~therp-nl/banking-addons/6.1-fix_workflow_stop_string_value_evaluates_to_True
Reviewer Review Type Date Requested Status
Nicolas Bessi - Camptocamp (community) Approve
Review via email: mp+141619@code.launchpad.net

Description of the change

This module attempts to unset a flow stop marker in the payment order workflow. However, it did so using the string 'False' which evaluates to True.

To post a comment you must log in.
Revision history for this message
Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'account_direct_debit/workflow/account_payment.xml'
--- account_direct_debit/workflow/account_payment.xml 2011-12-18 22:45:27 +0000
+++ account_direct_debit/workflow/account_payment.xml 2013-01-02 14:49:27 +0000
@@ -12,7 +12,7 @@
12 another state, 'sent_wait' between sent and done.12 another state, 'sent_wait' between sent and done.
13 -->13 -->
14 <record id="account_payment.act_done" model="workflow.activity">14 <record id="account_payment.act_done" model="workflow.activity">
15 <field name="flow_stop">False</field>15 <field name="flow_stop" eval="False"/>
16 </record>16 </record>
1717
18 <record id="trans_done_sent" model="workflow.transition">18 <record id="trans_done_sent" model="workflow.transition">

Subscribers

People subscribed via source and target branches