Merge lp:~thekorn/zeitgeist/fix-628661-make-check-doc into lp:zeitgeist/0.1

Proposed by Markus Korn
Status: Merged
Merged at revision: 1566
Proposed branch: lp:~thekorn/zeitgeist/fix-628661-make-check-doc
Merge into: lp:zeitgeist/0.1
Diff against target: 64 lines (+32/-2)
4 files modified
Makefile.am (+17/-0)
doc/Makefile.am (+3/-0)
po/POTFILES.skip (+1/-0)
test/run-all-tests.py (+11/-2)
To merge this branch: bzr merge lp:~thekorn/zeitgeist/fix-628661-make-check-doc
Reviewer Review Type Date Requested Status
Markus Korn Needs Fixing
Siegfried Gevatter Approve
Review via email: mp+34431@code.launchpad.net

Commit message

Adding 'make check' and 'make doc' commands to the rootlevel makefile (LP: #628661)

Description of the change

Adding 'make check' and 'make doc' to fix bug 628661.

To post a comment you must log in.
Revision history for this message
Siegfried Gevatter (rainct) wrote :

Great.

review: Approve
Revision history for this message
Markus Korn (thekorn) wrote :

Hmm, seems like it's not working, `make distcheck` fails

review: Needs Fixing
1567. By Markus Korn

Test if the testsuite is available to avoid errors in `make dictcheck` as we
do not ship the tests in our builds

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Makefile.am'
--- Makefile.am 2010-06-17 21:22:15 +0000
+++ Makefile.am 2010-09-03 10:20:59 +0000
@@ -62,3 +62,20 @@
62 else \62 else \
63 echo A Bazaar branch is required to generate the ChangeLog >&2; \63 echo A Bazaar branch is required to generate the ChangeLog >&2; \
64 fi64 fi
65
66# create API documentation
67doc: all
68 make -C doc/zeitgeist html
69
70.PHONY: doc
71
72# hook into the `make check` command to run the testsuite
73# if the testsuite is not available (e.g. in the tarball) do nothing
74# but printing a message
75check-local:
76 @if test -e "test/run-all-tests.py"; \
77 then \
78 test/run-all-tests.py; \
79 else \
80 echo "Cannot run the testsuite, tests are not shipped"; \
81 fi
6582
=== modified file 'doc/Makefile.am'
--- doc/Makefile.am 2009-12-16 08:59:10 +0000
+++ doc/Makefile.am 2010-09-03 10:20:59 +0000
@@ -5,3 +5,6 @@
5EXTRA_DIST = \5EXTRA_DIST = \
6 $(man_MANS) \6 $(man_MANS) \
7 zeitgeist7 zeitgeist
8
9clean: clean-am
10 make -C zeitgeist/ clean
811
=== added file 'po/POTFILES.skip'
--- po/POTFILES.skip 1970-01-01 00:00:00 +0000
+++ po/POTFILES.skip 2010-09-03 10:20:59 +0000
@@ -0,0 +1,1 @@
1tools/gtk/zeitgeist-data-sources-gtk.py
02
=== modified file 'test/run-all-tests.py'
--- test/run-all-tests.py 2010-05-15 13:05:14 +0000
+++ test/run-all-tests.py 2010-09-03 10:20:59 +0000
@@ -7,8 +7,17 @@
7import logging7import logging
8import sys8import sys
99
10# redirect all debugging output to stderr10from optparse import OptionParser
11logging.basicConfig(stream=sys.stderr)11parser = OptionParser()
12parser.add_option("-v", action="count", dest="verbosity")
13(options, args) = parser.parse_args()
14
15if options.verbosity:
16 # do more fine grained stuff later
17 # redirect all debugging output to stderr
18 logging.basicConfig(stream=sys.stderr)
19else:
20 logging.basicConfig(filename="/dev/null")
1221
13sys.path.insert(0, os.path.join(os.path.dirname(__file__), ".."))22sys.path.insert(0, os.path.join(os.path.dirname(__file__), ".."))
1423

Subscribers

People subscribed via source and target branches