Merge lp:~thekorn/launchpad/make_iperson_ihasbugs into lp:launchpad

[Markus Korn]

Person.searchTasks() is now exposed in the webservice API. This method queries the tasks related to a user. As a side effect of this implementation the official_bug_tags attribute was moved away from IHasBugs to IHasOfficialBugTags. Fixes bug 282178: "Make IPerson an IHasBugs and make sure calling searchTasks on it works"

[Markus Korn (thekorn)]

This is the first step to fix bug 282178 (making Person.searchTasks available over the webservice API)

This branch includes three different types of changes:
 * implemented Person.searchTasks() in a way that it can be called without BugTaskSearchParams and only by giving keyword arguments. Person.searchTasks() returns the same list of tasks which is shown as "related Bugs" in bugs.launchpad.net/~username.
 * as a person cannot have official_bug_tags this field is moved away from IHasBugs - thanks to Gavin Panella for helping me with the related changes.
 * added testcases for the internal API and the webservice API

The seconds step to fix the bug mentioned above will be to add (alias like) methods to IPerson (searchCommentedTasks(), searchSubscribedTasks() ...)

[Gavin Panella (allenap)]

Hi Markus,

I've added some comments to the diff below. It looks pretty good,
thank you so much for doing this.

Because I worked closely on you on this branch, I'm going to ask
someone else to review it too.

Gavin.

> === modified file 'lib/canonical/launchpad/interfaces/_schema_circular_imports.py'
> --- lib/canonical/launchpad/interfaces/_schema_circular_imports.py 2010-02-01 19:36:23 +0000
> +++ lib/canonical/launchpad/interfaces/_schema_circular_imports.py 2010-02-04 11:12:28 +0000
> @@ -24,11 +24,11 @@
>
> from lp.registry.interfaces.structuralsubscription import (
> IStructuralSubscription, IStructuralSubscriptionTarget)
> -from lp.bugs.interfaces.bug import IBug
> +from lp.bugs.interfaces.bug import IBug, IFrontPageBugAddForm
> from lp.bugs.interfaces.bugbranch import IBugBranch
> from lp.bugs.interfaces.bugnomination import IBugNomination
> from lp.bugs.interfaces.bugtask import IBugTask
> -from lp.bugs.interfaces.bugtarget import IHasBugs
> +from lp.bugs.interfaces.bugtarget import IHasBugs, IBugTarget
> from lp.soyuz.interfaces.build import (
> BuildStatus, IBuild)
> from lp.soyuz.interfaces.buildrecords import IHasBuildRecords
> @@ -69,6 +69,11 @@
> from lp.soyuz.interfaces.queue import (
> IPackageUpload, PackageUploadCustomFormat, PackageUploadStatus)
> from lp.registry.interfaces.sourcepackage import ISourcePackage
> +from canonical.launchpad.interfaces.message import (
> + IIndexedMessage, IMessage, IUserToUserEmail)
> +
> +from lp.bugs.interfaces.bugtracker import IBugTracker
> +from lp.bugs.interfaces.bugwatch import IBugWatch
>
>
> IBranch['bug_branches'].value_type.schema = IBugBranch
> @@ -312,5 +317,53 @@
> patch_reference_property(
> IStructuralSubscriptionTarget, 'parent_subscription_target',
> IStructuralSubscriptionTarget)
> -
> +
> IBuildBase['buildstate'].vocabulary = BuildStatus
> +
> +# IHasBugs
> +patch_plain_parameter_type(
> + IHasBugs, 'searchTasks', 'assignee', IPerson)
> +patch_plain_parameter_type(
> + IHasBugs, 'searchTasks', 'bug_reporter', IPerson)
> +patch_plain_parameter_type(
> + IHasBugs, 'searchTasks', 'bug_supervisor', IPerson)
> +patch_plain_parameter_type(
> + IHasBugs, 'searchTasks', 'bug_commenter', IPerson)
> +patch_plain_parameter_type(
> + IHasBugs, 'searchTasks', 'bug_subscriber', IPerson)
> +patch_plain_parameter_type(
> + IHasBugs, 'searchTasks', 'owner', IPerson)
> +patch_plain_parameter_type(
> + IHasBugs, 'searchTasks', 'affected_user', IPerson)
> +
> +# IBugTask
> +patch_reference_property(IBugTask, 'owner', IPerson)
> +
> +# IBugWatch
> +patch_reference_property(IBugWatch, 'owner', IPerson)
> +
> +# IIndexedMessage
> +patch_reference_property(IIndexedMessage, 'inside', IBugTask)
> +
> +# IMessage
> +patch_reference_property(IMessage, 'owner', IPerson)
> +
> +# IUserToUserEmail
> +patch_reference_property(IUserToUserEmail, 'sender', IPerson)
> +patch_reference_property(IUserToUserEmail, 'recipient', IPerson)
> +
> +# IBug
> +patch_plain_parameter_type(
> + IBug, 'addNomination', 'target', IBugTarget)
> +patch_plain_parameter_type(
> + IBug, 'canBeNominatedFor', 'target', IBugTarget)
> +patch_plain_parameter_type(
> +...

review: Abstain

[Eleanor Berger (intellectronica)]

Markus (and Gavin), thanks a lot for picking this up. Excellent branch! I have no comments beyond what Gavin already mentioned in his review. I'm leaving the branch in NEEDS FIXING, since you'll need to fix them and then ask one of us to merge it on your behalf, but this shouldn't be much work.

review: Needs Fixing (code)

[lp:~thekorn/launchpad/make_iperson_ihasbugs]

10114. By Markus Korn on 2010-02-04

fixed typo

10115. By Markus Korn on 2010-02-04

started to address some comments of the review

10116. By Markus Korn on 2010-02-08

merged devel

10117. By Markus Korn on 2010-02-10

* merged devel
* fixed conflicting base classes of IPersonPublic

10118. By Markus Korn on 2010-02-10

* Added IllegalRelatedBugTasksParams Exception which translates to a 400
  HTTP error in the webservice API and will be raised in cases of invalid
  queries for related tasks

10119. By Markus Korn on 2010-02-10

* moved creation of BugTaskSearchParams for Person.searchTasks() to an
  external function.
* added more comments to document the behaviour of this function
* raise IllegalRelatedBugTasksParams exception in case it is impossible to
  execute Person.searchTasks() because of invalid number of parameters

10120. By Markus Korn on 2010-02-10

* moved doctest for Person.searchTasks() to xx-bug.txt

10121. By Markus Korn on 2010-02-10

* added unittests for getRelatedBugTasksParams

[Markus Korn (thekorn)]

Thanks for your review Gavin, I tried to address as many points as possible in the recent commits, most importantly I moved the logic to create search parameters into a separate function, added a few more descriptive comments/docstrings, moved the doctest into xx-bug.txt and added unittests for the new function.

review: Needs Resubmitting

[Eleanor Berger (intellectronica)]

Very nice. r=me.

Set the commit message and I'll land this on your behalf.

Thanks a lot for working on this!

review: Approve (code)

[Gavin Panella (allenap)]

Hi Markus,

I've gone through each revision in turn since the last review; I
couldn't figure out how to get a cumulative diff without pulling in
all the merges from devel.

There are still a few things left to do to get this ready for landing,
but they're not huge, and I've done some of them (a few more unit
tests). It's really close though.

Gavin.

Revision 10114:
> === modified file 'lib/lp/bugs/doc/bugtask-search.txt'
> --- lib/lp/bugs/doc/bugtask-search.txt 2010-02-02 03:23:24 +0000
> +++ lib/lp/bugs/doc/bugtask-search.txt 2010-02-04 15:33:37 +0000
> @@ -65,7 +65,7 @@
> == Person bugs ==
>
> To get all related tasks to a person call searchTasks() on the person
> -pbject:
> +object:
>
> >>> from canonical.launchpad.interfaces import IPersonSet
> >>> user = getUtility(IPersonSet).getByName('name16')
>

Revision 10115:
> === modified file 'lib/lp/registry/model/person.py'
> --- lib/lp/registry/model/person.py 2010-02-03 14:18:27 +0000
> +++ lib/lp/registry/model/person.py 2010-02-04 16:34:53 +0000
> @@ -31,7 +31,6 @@
> import random
> import re
> import weakref
> -import copy
>
> from zope.lifecycleevent import ObjectCreatedEvent
> from zope.interface import alsoProvides, implementer, implements
> @@ -838,16 +837,20 @@
>
> def searchTasks(self, search_params, *args, **kwargs):
> """See `IHasBugs`."""
> - if search_params is None and not args:
> + if search_params is None and len(args) == 0:
> # this method is called via webapi directly
> - args = list()
> + args = []
> for key in ('assignee', 'bug_subscriber', 'owner', 'bug_commenter'):
> - if kwargs.get(key, None) is None:
> - arguments = copy.copy(kwargs)
> + # all these parameter default to None
> +
> + if kwargs.get(key) is None:
> +
> + arguments = kwargs.copy()
> arguments[key] = self
> if key == 'owner':
> - # Specify both owner and bug_reporter to try to prevent the same
> - # bug (but different tasks) being displayed.
> + # Specify both owner and bug_reporter to try to
> + # prevent the same bug (but different tasks)
> + # being displayed.
> # see `PersonRelatedBugTaskSearchListingView.searchUnbatched`
> arguments['bug_reporter'] = self
> args.append(BugTaskSearchParams.fromSearchForm(**arguments))
>

Revision 10118:
> === modified file 'lib/lp/registry/interfaces/person.py'
> --- lib/lp/registry/interfaces/person.py 2010-02-10 07:36:25 +0000
> +++ lib/lp/registry/interfaces/person.py 2010-02-10 10:51:00 +0000
> @@ -25,6 +25,7 @@
> 'ITeamContactAddressForm',
> 'ITeamCreation',
> 'ITeamReassignment',
> + 'IllegalRelatedBugTasksParams',
> 'ImmutableVisibilityError',
> 'InvalidName',
> 'JoinNotAllowed',
> @@ -2057,6 +2058,12 @@
> webservice_error(409)
>
>
> +class IllegalRelatedBugTasksParams(Exception):
> + """Exception raised when trying to ov...

review: Needs Fixing

[lp:~thekorn/launchpad/make_iperson_ihasbugs]

10122. By Markus Korn on 2010-02-11

fixed typo in docstring of IllegalRelatedBugTasksParams

10123. By Markus Korn on 2010-02-11

* renamed `getRelatedBugTasksParams` into
  `get_related_bugtasks_search_params` and moved this function to
  lp.bugs.model.bugtask
* checking type of context argument of get_related_bugtasks_search_params()
*

10124. By Markus Korn on 2010-02-11

* moved IllegalRelatedBugTasksParams to lp.bugs.interfaces.bugtask

10125. By Markus Korn on 2010-02-11

* added webservice API test for IllegalRelatedBugTasksParams

10126. By Markus Korn on 2010-02-11

* Merged Gavin Panella's changes to the unittests for the related bug task
  search.

10127. By Markus Korn on 2010-02-12

added more detailed doctests to Person.searchTasks()

[Markus Korn (thekorn)]

With r10127 I *think* I've addressed all of Gavin's comments

review: Needs Resubmitting

[lp:~thekorn/launchpad/make_iperson_ihasbugs]

10128. By Markus Korn on 2010-02-12

removed trailing whitespaces from lib/canonical/launchpad/interfaces/_schema_circular_imports.py

10129. By Markus Korn on 2010-02-12

removed trailing whitespaces from lib/lp/bugs/doc/bugtask-search.txt

10130. By Markus Korn on 2010-02-12

removed trailing whitespaces from lib/lp/bugs/interfaces/bugtask.py

10131. By Markus Korn on 2010-02-12

removed trailing whitespaces from lib/lp/bugs/stories/webservice/xx-bug.txt

10132. By Markus Korn on 2010-02-12

merged with devel

10133. By Markus Korn on 2010-02-12

removed trailing whitespaces from lib/lp/registry/interfaces/distributionsourcepackage.py

10134. By Markus Korn on 2010-02-12

removed trailing whitespaces from lib/lp/registry/interfaces/distroseries.py

[Markus Korn (thekorn)]

fixed bunch of trailing whitespaces.

Now I get messages from `make lint` for code I did not even touch directly

review: Needs Resubmitting

[Gavin Panella (allenap)]

As discussed on IRC earlier, you accidentally merged db-devel instead of devel at revision 10132. My branch lp:~allenap/launchpad/make_iperson_ihasbugs fixes this and also removes the remaining trailing white-space from the branch.

Right, I'll get it landed now :)

review: Approve

[Gavin Panella (allenap)]

Merged via lp:~allenap/launchpad/make_iperson_ihasbugs.

=== modified file 'lib/canonical/launchpad/interfaces/_schema_circular_imports.py'
--- lib/canonical/launchpad/interfaces/_schema_circular_imports.py	2010-02-11 00:54:32 +0000
+++ lib/canonical/launchpad/interfaces/_schema_circular_imports.py	2010-02-12 10:32:22 +0000
@@ -24,11 +24,11 @@
 
 from lp.registry.interfaces.structuralsubscription import (
     IStructuralSubscription, IStructuralSubscriptionTarget)
-from lp.bugs.interfaces.bug import IBug
+from lp.bugs.interfaces.bug import IBug, IFrontPageBugAddForm
 from lp.bugs.interfaces.bugbranch import IBugBranch
 from lp.bugs.interfaces.bugnomination import IBugNomination
 from lp.bugs.interfaces.bugtask import IBugTask
-from lp.bugs.interfaces.bugtarget import IHasBugs
+from lp.bugs.interfaces.bugtarget import IHasBugs, IBugTarget
 from lp.soyuz.interfaces.build import (
     BuildStatus, IBuild)
 from lp.soyuz.interfaces.buildrecords import IHasBuildRecords
@@ -70,6 +70,11 @@
 from lp.soyuz.interfaces.queue import (
     IPackageUpload, PackageUploadCustomFormat, PackageUploadStatus)
 from lp.registry.interfaces.sourcepackage import ISourcePackage
+from canonical.launchpad.interfaces.message import (
+    IIndexedMessage, IMessage, IUserToUserEmail)
+
+from lp.bugs.interfaces.bugtracker import IBugTracker
+from lp.bugs.interfaces.bugwatch import IBugWatch
 
 
 IBranch['bug_branches'].value_type.schema = IBugBranch
@@ -315,3 +320,51 @@
     IStructuralSubscriptionTarget)
 
 IBuildBase['buildstate'].vocabulary = BuildStatus
+
+# IHasBugs
+patch_plain_parameter_type(
+    IHasBugs, 'searchTasks', 'assignee', IPerson)
+patch_plain_parameter_type(
+    IHasBugs, 'searchTasks', 'bug_reporter', IPerson)
+patch_plain_parameter_type(
+    IHasBugs, 'searchTasks', 'bug_supervisor', IPerson)
+patch_plain_parameter_type(
+    IHasBugs, 'searchTasks', 'bug_commenter', IPerson)
+patch_plain_parameter_type(
+    IHasBugs, 'searchTasks', 'bug_subscriber', IPerson)
+patch_plain_parameter_type(
+    IHasBugs, 'searchTasks', 'owner', IPerson)
+patch_plain_parameter_type(
+    IHasBugs, 'searchTasks', 'affected_user', IPerson)
+
+# IBugTask
+patch_reference_property(IBugTask, 'owner', IPerson)
+
+# IBugWatch
+patch_reference_property(IBugWatch, 'owner', IPerson)
+
+# IIndexedMessage
+patch_reference_property(IIndexedMessage, 'inside', IBugTask)
+
+# IMessage
+patch_reference_property(IMessage, 'owner', IPerson)
+
+# IUserToUserEmail
+patch_reference_property(IUserToUserEmail, 'sender', IPerson)
+patch_reference_property(IUserToUserEmail, 'recipient', IPerson)
+
+# IBug
+patch_plain_parameter_type(
+    IBug, 'addNomination', 'target', IBugTarget)
+patch_plain_parameter_type(
+    IBug, 'canBeNominatedFor', 'target', IBugTarget)
+patch_plain_parameter_type(
+    IBug, 'getNominationFor', 'target', IBugTarget)
+patch_plain_parameter_type(
+    IBug, 'getNominations', 'target', IBugTarget)
+
+# IFrontPageBugAddForm
+patch_reference_property(IFrontPageBugAddForm, 'bugtarget', IBugTarget)
+
+# IBugTracker
+patch_reference_property(IBugTracker, 'owner', IPerson)
 
=== modified file 'lib/canonical/launchpad/interfaces/message.py'
--- lib/canonical/launchpad/interfaces/message.py	2009-12-01 11:53:59 +0000
+++ lib/canonical/launchpad/interfaces/message.py	2010-02-12 10:32:22 +0000
@@ -27,10 +27,8 @@
 
 from canonical.launchpad import _
 from canonical.launchpad.interfaces import NotFoundError
-from lp.bugs.interfaces.bugtask import IBugTask
 from lp.services.job.interfaces.job import IJob
 from canonical.launchpad.interfaces.librarian import ILibraryFileAlias
-from lp.registry.interfaces.person import IPerson
 
 from lazr.delegates import delegates
 from lazr.restful.fields import CollectionField, Reference
@@ -57,7 +55,7 @@
     # add form used by MessageAddView.
     content = Text(title=_("Message"), required=True, readonly=True)
     owner = exported(
-        Reference(title=_('Person'), schema=IPerson,
+        Reference(title=_('Person'), schema=Interface,
                   required=False, readonly=True))
 
     # Schema is really IMessage, but this cannot be declared here. It's
@@ -181,7 +179,7 @@
 
 class IIndexedMessage(Interface):
     """An `IMessage` decorated with its index and context."""
-    inside = Reference(title=_('Inside'), schema=IBugTask,
+    inside = Reference(title=_('Inside'), schema=Interface,
                        description=_("The bug task which is "
                                      "the context for this message."),
                        required=True, readonly=True)
@@ -227,12 +225,12 @@
     """User to user direct email communications."""
 
     sender = Object(
-        schema=IPerson,
+        schema=Interface,
         title=_("The message sender"),
         required=True, readonly=True)
 
     recipient = Object(
-        schema=IPerson,
+        schema=Interface,
         title=_("The message recipient"),
         required=True, readonly=True)
 
 
=== modified file 'lib/lp/bugs/doc/bugtask-search.txt'
--- lib/lp/bugs/doc/bugtask-search.txt	2010-02-02 17:12:29 +0000
+++ lib/lp/bugs/doc/bugtask-search.txt	2010-02-12 10:32:22 +0000
@@ -62,6 +62,17 @@
     >>> ubuntu_firefox_bugs.count() > 0
     True
 
+== Person bugs ==
+
+To get all related tasks to a person call searchTasks() on the person
+object:
+
+    >>> from canonical.launchpad.interfaces import IPersonSet
+    >>> user = getUtility(IPersonSet).getByName('name16')
+    >>> user_bugs = user.searchTasks(None, user=None)
+    >>> user_bugs.count() > 0
+    True
+
 == Dupes and Conjoined tasks ==
 
 You can set flags to omit duplicates:
@@ -962,7 +973,7 @@
     >>> print reduce(
     ...     lambda x, y: x and y,
     ...     [task.bug.isUserAffected(foo_bar)
-    ...      for task in firefox.searchTasks(search_params)]) 
+    ...      for task in firefox.searchTasks(search_params)])
     True
 
 
 
=== modified file 'lib/lp/bugs/interfaces/bug.py'
--- lib/lp/bugs/interfaces/bug.py	2010-01-23 21:42:36 +0000
+++ lib/lp/bugs/interfaces/bug.py	2010-02-12 10:32:22 +0000
@@ -33,7 +33,6 @@
 from canonical.launchpad.fields import (
     BugField, ContentNameField, DuplicateBug, PublicPersonChoice, Tag, Title)
 from lp.bugs.interfaces.bugattachment import IBugAttachment
-from lp.bugs.interfaces.bugtarget import IBugTarget
 from lp.bugs.interfaces.bugtask import (
     BugTaskImportance, BugTaskStatus, IBugTask)
 from lp.bugs.interfaces.bugwatch import IBugWatch
@@ -587,7 +586,7 @@
         """Create an INullBugTask and return it for the given parameters."""
 
     @operation_parameters(
-        target=Reference(schema=IBugTarget, title=_('Target')))
+        target=Reference(schema=Interface, title=_('Target')))
     @call_with(owner=REQUEST_USER)
     @export_factory_operation(Interface, [])
     def addNomination(owner, target):
@@ -601,7 +600,7 @@
         """
 
     @operation_parameters(
-        target=Reference(schema=IBugTarget, title=_('Target')))
+        target=Reference(schema=Interface, title=_('Target')))
     @export_read_operation()
     def canBeNominatedFor(target):
         """Can this bug nominated for this target?
@@ -612,7 +611,7 @@
         """
 
     @operation_parameters(
-        target=Reference(schema=IBugTarget, title=_('Target')))
+        target=Reference(schema=Interface, title=_('Target')))
     @operation_returns_entry(Interface)
     @export_read_operation()
     def getNominationFor(target):
@@ -625,7 +624,7 @@
 
     @operation_parameters(
         target=Reference(
-            schema=IBugTarget, title=_('Target'), required=False),
+            schema=Interface, title=_('Target'), required=False),
         nominations=List(
             title=_("Nominations to search through."),
             value_type=Reference(schema=Interface), # IBugNomination
@@ -895,7 +894,7 @@
     """Create a bug for any bug target."""
 
     bugtarget = Reference(
-        schema=IBugTarget, title=_("Where did you find the bug?"),
+        schema=Interface, title=_("Where did you find the bug?"),
         required=True)
 
 
 
=== modified file 'lib/lp/bugs/interfaces/bugtarget.py'
--- lib/lp/bugs/interfaces/bugtarget.py	2009-08-18 11:12:06 +0000
+++ lib/lp/bugs/interfaces/bugtarget.py	2010-02-12 10:32:22 +0000
@@ -25,7 +25,6 @@
 from canonical.launchpad.fields import Tag
 from lp.bugs.interfaces.bugtask import (
     BugTagsSearchCombinator, IBugTask, IBugTaskSearch)
-from lp.registry.interfaces.person import IPerson
 from lazr.enum import DBEnumeratedType
 from lazr.restful.fields import Reference
 from lazr.restful.interface import copy_field
@@ -56,11 +55,6 @@
         "A list of unassigned BugTasks for this target.")
     all_bugtasks = Attribute(
         "A list of all BugTasks ever reported for this target.")
-    official_bug_tags = exported(List(
-        title=_("Official Bug Tags"),
-        description=_("The list of bug tags defined as official."),
-        value_type=Tag(),
-        readonly=True))
 
     @call_with(search_params=None, user=REQUEST_USER)
     @operation_parameters(
@@ -71,13 +65,13 @@
         search_text=copy_field(IBugTaskSearch['searchtext']),
         status=copy_field(IBugTaskSearch['status']),
         importance=copy_field(IBugTaskSearch['importance']),
-        assignee=Reference(schema=IPerson),
-        bug_reporter=Reference(schema=IPerson),
-        bug_supervisor=Reference(schema=IPerson),
-        bug_commenter=Reference(schema=IPerson),
-        bug_subscriber=Reference(schema=IPerson),
-        owner=Reference(schema=IPerson),
-        affected_user=Reference(schema=IPerson),
+        assignee=Reference(schema=Interface),
+        bug_reporter=Reference(schema=Interface),
+        bug_supervisor=Reference(schema=Interface),
+        bug_commenter=Reference(schema=Interface),
+        bug_subscriber=Reference(schema=Interface),
+        owner=Reference(schema=Interface),
+        affected_user=Reference(schema=Interface),
         has_patch=copy_field(IBugTaskSearch['has_patch']),
         has_cve=copy_field(IBugTaskSearch['has_cve']),
         tags=copy_field(IBugTaskSearch['tag']),
@@ -278,13 +272,21 @@
         self.status = status
 
 
-class IOfficialBugTagTargetPublic(Interface):
+class IHasOfficialBugTags(Interface):
+    """An entity that exposes a set of official bug tags."""
+
+    official_bug_tags = exported(List(
+        title=_("Official Bug Tags"),
+        description=_("The list of bug tags defined as official."),
+        value_type=Tag(),
+        readonly=True))
+
+
+class IOfficialBugTagTargetPublic(IHasOfficialBugTags):
     """Public attributes for `IOfficialBugTagTarget`."""
 
-    official_bug_tags = exported(List(
-        title=_("Official Bug Tags"),
-        description=_("The list of bug tags defined as official."),
-        value_type=Tag()))
+    official_bug_tags = copy_field(
+        IHasOfficialBugTags['official_bug_tags'], readonly=False)
 
 
 class IOfficialBugTagTargetRestricted(Interface):
 
=== modified file 'lib/lp/bugs/interfaces/bugtask.py'
--- lib/lp/bugs/interfaces/bugtask.py	2010-02-05 16:00:51 +0000
+++ lib/lp/bugs/interfaces/bugtask.py	2010-02-12 10:32:22 +0000
@@ -26,6 +26,7 @@
     'IDistroBugTask',
     'IDistroSeriesBugTask',
     'IFrontPageBugTaskSearch',
+    'IllegalRelatedBugTasksParams',
     'IllegalTarget',
     'INominationsReviewTableBatchNavigator',
     'INullBugTask',
@@ -60,7 +61,6 @@
 from lp.soyuz.interfaces.component import IComponent
 from canonical.launchpad.interfaces.launchpad import IHasDateCreated, IHasBug
 from lp.registry.interfaces.mentoringoffer import ICanBeMentored
-from lp.registry.interfaces.person import IPerson
 from canonical.launchpad.searchbuilder import all, any, NULL
 from canonical.launchpad.validators import LaunchpadValidationError
 from canonical.launchpad.validators.name import name_validator
@@ -340,6 +340,13 @@
     """Exception raised when trying to set an illegal bug task target."""
     webservice_error(400) #Bad request.
 
+
+class IllegalRelatedBugTasksParams(Exception):
+    """Exception raised when trying to overwrite all relevant parameters
+    in a search for related bug tasks"""
+    webservice_error(400) #Bad request.
+
+
 class IBugTask(IHasDateCreated, IHasBug, ICanBeMentored):
     """A bug needing fixing in a particular product or package."""
     export_as_webservice_entry()
@@ -474,7 +481,7 @@
             description=_("The age of this task in seconds, a delta between "
                          "now and the date the bug task was created."))
     owner = exported(
-        Reference(title=_("The owner"), schema=IPerson, readonly=True))
+        Reference(title=_("The owner"), schema=Interface, readonly=True))
     target = exported(Reference(
         title=_('Target'), required=True, schema=Interface, # IBugTarget
         readonly=True,
 
=== modified file 'lib/lp/bugs/interfaces/bugtracker.py'
--- lib/lp/bugs/interfaces/bugtracker.py	2009-12-14 13:51:00 +0000
+++ lib/lp/bugs/interfaces/bugtracker.py	2010-02-12 10:32:22 +0000
@@ -27,7 +27,6 @@
 from canonical.launchpad import _
 from canonical.launchpad.fields import (
     ContentNameField, StrippedTextLine, URIField)
-from lp.registry.interfaces.person import IPerson
 from canonical.launchpad.validators import LaunchpadValidationError
 from canonical.launchpad.validators.name import name_validator
 
@@ -216,7 +215,7 @@
             required=False),
         exported_as='base_url_aliases')
     owner = exported(
-        Reference(title=_('Owner'), schema=IPerson),
+        Reference(title=_('Owner'), schema=Interface),
         exported_as='registrant')
     contactdetails = exported(
         Text(
 
=== modified file 'lib/lp/bugs/interfaces/bugwatch.py'
--- lib/lp/bugs/interfaces/bugwatch.py	2009-12-22 16:32:42 +0000
+++ lib/lp/bugs/interfaces/bugwatch.py	2010-02-12 10:32:22 +0000
@@ -22,7 +22,6 @@
 from canonical.launchpad import _
 from canonical.launchpad.fields import StrippedTextLine
 from canonical.launchpad.interfaces.launchpad import IHasBug
-from lp.registry.interfaces.person import IPerson
 from lp.bugs.interfaces.bugtracker import IBugTracker
 
 from lazr.restful.declarations import (
@@ -134,7 +133,7 @@
         exported_as='date_created')
     owner = exported(
         Reference(title=_('Owner'), required=True,
-                  readonly=True, schema=IPerson))
+                  readonly=True, schema=Interface))
 
     # Useful joins.
     bugtasks = exported(
 
=== modified file 'lib/lp/bugs/model/bugtask.py'
--- lib/lp/bugs/model/bugtask.py	2010-02-02 17:12:29 +0000
+++ lib/lp/bugs/model/bugtask.py	2010-02-12 10:32:22 +0000
@@ -16,6 +16,7 @@
     'NullBugTask',
     'bugtask_sort_key',
     'get_bug_privacy_filter',
+    'get_related_bugtasks_search_params',
     'search_value_to_where_condition']
 
 
@@ -61,7 +62,7 @@
     INullBugTask, IProductSeriesBugTask, IUpstreamBugTask, IllegalTarget,
     RESOLVED_BUGTASK_STATUSES, UNRESOLVED_BUGTASK_STATUSES,
     UserCannotEditBugTaskImportance, UserCannotEditBugTaskMilestone,
-    UserCannotEditBugTaskStatus)
+    UserCannotEditBugTaskStatus, IllegalRelatedBugTasksParams)
 from lp.bugs.model.bugsubscription import BugSubscription
 from lp.registry.interfaces.distribution import (
     IDistribution, IDistributionSet)
@@ -82,7 +83,8 @@
 from canonical.launchpad.searchbuilder import (
     all, any, greater_than, NULL, not_equals)
 from lp.registry.interfaces.person import (
-    validate_person_not_private_membership, validate_public_person)
+    IPerson, validate_person_not_private_membership,
+    validate_public_person)
 from canonical.launchpad.webapp.interfaces import (
         IStoreSelector, DEFAULT_FLAVOR, MAIN_STORE, NotFoundError)
 
@@ -137,6 +139,48 @@
     return (
         bugtask.bug.id, distribution_name, product_name, productseries_name,
         distroseries_name, sourcepackage_name)
+    
+def get_related_bugtasks_search_params(user, context, **kwargs):
+    """Returns a list of `BugTaskSearchParams` which can be used to
+    search for all tasks related to a user given by `context`.
+    
+    Which tasks are related to a user?
+      * the user has to be either assignee or owner of this tasks
+        OR
+      * the user has to be subscriber or commenter to the underlying bug
+        OR
+      * the user is reporter of the underlying bug, but this condition
+        is automatically fulfilled by the first one as each new bug
+        always get one task owned by the bug reporter
+    """
+    assert IPerson.providedBy(context), "Context argument needs to be IPerson"
+    relevant_fields = ('assignee', 'bug_subscriber', 'owner', 'bug_commenter')
+    search_params = []
+    for key in relevant_fields:
+        # all these parameter default to None
+        user_param = kwargs.get(key)
+        if user_param is None or user_param == context:
+            # we are only creating a `BugTaskSearchParams` object if
+            # the field is None or equal to the context
+            arguments = kwargs.copy()
+            arguments[key] = context
+            if key == 'owner':
+                # Specify both owner and bug_reporter to try to
+                # prevent the same bug (but different tasks)
+                # being displayed.
+                # see `PersonRelatedBugTaskSearchListingView.searchUnbatched`
+                arguments['bug_reporter'] = context
+            search_params.append(
+                BugTaskSearchParams.fromSearchForm(user, **arguments))
+    if len(search_params) == 0:
+        # unable to search for related tasks to user_context because user
+        # modified the query in an invalid way by overwriting all user
+        # related parameters
+        raise IllegalRelatedBugTasksParams(
+            ('Cannot search for related tasks to \'%s\', at least one '
+             'of these parameter has to be empty: %s'
+                %(context.name, ", ".join(relevant_fields))))
+    return search_params
 
 
 class BugTaskDelta:
 
=== modified file 'lib/lp/bugs/stories/webservice/xx-bug.txt'
--- lib/lp/bugs/stories/webservice/xx-bug.txt	2010-02-04 21:18:35 +0000
+++ lib/lp/bugs/stories/webservice/xx-bug.txt	2010-02-12 10:32:22 +0000
@@ -676,7 +676,7 @@
     ...
     Location: http://.../bugs/.../nominations/...
     ...
-  
+
     >>> nominations = webservice.named_get(
     ...     '/bugs/%d' % bug.id, 'getNominations').jsonBody()
     >>> pprint_collection(nominations)
@@ -699,7 +699,7 @@
 John cannot approve or decline the nomination.
 
     >>> nom_url = nominations['entries'][0]['self_link']
-    
+
     >>> print john_webservice.named_get(nom_url, 'canApprove').jsonBody()
     False
 
@@ -715,9 +715,9 @@
     >>> logout()
 
 Eric, however, can and does decline the nomination.
-    
+
     >>> eric_webservice = webservice_for_person(
-    ...     eric, permission=OAuthPermission.WRITE_PRIVATE)    
+    ...     eric, permission=OAuthPermission.WRITE_PRIVATE)
     >>> print eric_webservice.named_post(nom_url, 'decline')
     HTTP/1.1 200 Ok...
 
@@ -1645,6 +1645,76 @@
     http://api.launchpad.dev/beta/ubuntu/+source/linux-source-2.6.15/+bug/10
 
 
+User related bug tasks
+~~~~~~~~~~~~~~~~~~~~~~
+
+Calling searchTasks() on a Person object returns a collection of tasks
+related to this person.
+
+First create some sample data
+
+    >>> login('[e-mail]')
+    >>> testuser1 = factory.makePerson(name='testuser1')
+    >>> testuser2 = factory.makePerson(name='testuser2')
+    >>> testuser3 = factory.makePerson(name='testuser3')
+    >>> testbug1 = factory.makeBug(owner=testuser1)
+    >>> testbug2 = factory.makeBug(owner=testuser1)
+    >>> subscription = testbug2.subscribe(testuser2, testuser2)
+    >>> logout()
+
+There are two tasks related to `testuser1`, the initial tasks of both
+bugs:
+
+    >>> related = webservice.named_get(
+    ...     '/~testuser1', 'searchTasks'
+    ...     ).jsonBody()
+    >>> pprint_collection(related)
+    start: 0
+    total_size: 2
+    ---
+    ...
+    owner_link: u'http://api.launchpad.dev/beta/~testuser1'
+    ...
+    ---
+    ...
+    owner_link: u'http://api.launchpad.dev/beta/~testuser1'
+    ...
+
+`testuser2` is subscribed to `testbugs2`, so this bug is related to this
+user:
+
+    >>> related = webservice.named_get(
+    ...     '/~testuser2', 'searchTasks'
+    ...     ).jsonBody()
+    >>> len(related['entries']) == 1
+    True
+    >>> int(related['entries'][0]['bug_link'].split('/')[-1]) == testbug2.id
+    True
+
+`testuser3` is not active, so the collection of related tasks to him is
+empty:
+
+    >>> related = webservice.named_get(
+    ...     '/~testuser3', 'searchTasks'
+    ...     ).jsonBody()
+    >>> pprint_collection(related)
+    start: None
+    total_size: 0
+    ---
+
+You are not allowed to overwrite all user related parameter in the same
+query, because in this case this bug will no be related to the person
+anymore. In this case a `400 Bad Request`-Error will be returned
+
+    >>> name12 = webservice.get("/~name12").jsonBody()
+    >>> print webservice.named_get(
+    ...     '/~name16', 'searchTasks', assignee=name12['self_link'],
+    ...     owner=name12['self_link'], bug_subscriber=name12['self_link'],
+    ...     bug_commenter=name12['self_link']
+    ...     )
+    HTTP/1.1 400 Bad Request...
+
+
 Affected users
 --------------
 
 
=== modified file 'lib/lp/registry/configure.zcml'
--- lib/lp/registry/configure.zcml	2010-02-10 10:37:16 +0000
+++ lib/lp/registry/configure.zcml	2010-02-12 10:32:22 +0000
@@ -905,6 +905,8 @@
         <allow
             interface="lp.bugs.interfaces.bugtarget.IHasBugs"/>
         <allow
+            interface="lp.bugs.interfaces.bugtarget.IHasOfficialBugTags"/>
+        <allow
             interface="canonical.launchpad.webapp.interfaces.IAuthorization"/>
         <require
             permission="launchpad.Edit"
 
=== modified file 'lib/lp/registry/interfaces/distribution.py'
--- lib/lp/registry/interfaces/distribution.py	2010-02-04 21:18:32 +0000
+++ lib/lp/registry/interfaces/distribution.py	2010-02-12 10:32:22 +0000
@@ -532,13 +532,6 @@
     """An operating system distribution."""
     export_as_webservice_entry()
 
-# Patch the official_bug_tags field to make sure that it's
-# writable from the API, and not readonly like its definition
-# in IHasBugs.
-writable_obt_field = copy_field(IDistribution['official_bug_tags'])
-writable_obt_field.readonly = False
-IDistribution._v_attrs['official_bug_tags'] = writable_obt_field
-
 
 class IBaseDistribution(IDistribution):
     """A Distribution that is the base for other Distributions."""
 
=== modified file 'lib/lp/registry/interfaces/distributionsourcepackage.py'
--- lib/lp/registry/interfaces/distributionsourcepackage.py	2009-12-05 18:37:28 +0000
+++ lib/lp/registry/interfaces/distributionsourcepackage.py	2010-02-12 10:32:22 +0000
@@ -21,7 +21,7 @@
     rename_parameters_as)
 
 from canonical.launchpad import _
-from lp.bugs.interfaces.bugtarget import IBugTarget
+from lp.bugs.interfaces.bugtarget import IBugTarget, IHasOfficialBugTags
 from lp.bugs.interfaces.bugtask import IBugTask
 from lp.code.interfaces.hasbranches import IHasBranches, IHasMergeProposals
 from lp.registry.interfaces.distribution import IDistribution
@@ -31,7 +31,8 @@
 
 
 class IDistributionSourcePackage(IBugTarget, IHasBranches, IHasMergeProposals,
-                                 IStructuralSubscriptionTarget):
+                                 IStructuralSubscriptionTarget,
+                                 IHasOfficialBugTags):
     """Represents a source package in a distribution.
 
     Create IDistributionSourcePackages by invoking
@@ -101,7 +102,7 @@
         """
 
     def get_distroseries_packages(active_only=True):
-        """Return a list of DistroSeriesSourcePackage objects, each 
+        """Return a list of DistroSeriesSourcePackage objects, each
         representing this same source package in the series of this
         distribution.
 
 
=== modified file 'lib/lp/registry/interfaces/distroseries.py'
--- lib/lp/registry/interfaces/distroseries.py	2010-01-21 17:49:38 +0000
+++ lib/lp/registry/interfaces/distroseries.py	2010-02-12 10:32:22 +0000
@@ -28,7 +28,8 @@
 from lp.registry.interfaces.series import SeriesStatus
 from lp.registry.interfaces.structuralsubscription import (
     IStructuralSubscriptionTarget)
-from lp.bugs.interfaces.bugtarget import IBugTarget, IHasBugs
+from lp.bugs.interfaces.bugtarget import (
+    IBugTarget, IHasBugs, IHasOfficialBugTags)
 from lp.soyuz.interfaces.buildrecords import IHasBuildRecords
 from lp.translations.interfaces.languagepack import ILanguagePack
 from canonical.launchpad.interfaces.launchpad import (
@@ -154,7 +155,8 @@
 
 class IDistroSeriesPublic(IHasAppointedDriver, IHasDrivers, IHasOwner,
                           IBugTarget, ISpecificationGoal, IHasMilestones,
-                          IHasBuildRecords, ISeriesMixin):
+                          IHasBuildRecords, ISeriesMixin,
+                          IHasOfficialBugTags):
     """Public IDistroSeries properties."""
 
     id = Attribute("The distroseries's unique number.")
@@ -389,7 +391,7 @@
     def getDistroArchSeriesByProcessor(processor):
         """Return the distroarchseries for this distroseries with the
         given architecturetag from a `IProcessor`.
-        
+
         :param processor: An `IProcessor`
         :return: An `IDistroArchSeries` or None when none was found.
         """
 
=== modified file 'lib/lp/registry/interfaces/milestone.py'
--- lib/lp/registry/interfaces/milestone.py	2010-01-27 19:12:10 +0000
+++ lib/lp/registry/interfaces/milestone.py	2010-02-12 10:32:22 +0000
@@ -21,7 +21,7 @@
 from lp.registry.interfaces.structuralsubscription import (
     IStructuralSubscriptionTarget)
 from lp.registry.interfaces.productrelease import IProductRelease
-from lp.bugs.interfaces.bugtarget import IHasBugs
+from lp.bugs.interfaces.bugtarget import IHasBugs, IHasOfficialBugTags
 from lp.bugs.interfaces.bugtask import IBugTask
 from canonical.launchpad import _
 from canonical.launchpad.fields import (
@@ -70,7 +70,8 @@
         return milestone
 
 
-class IMilestone(IHasBugs, IStructuralSubscriptionTarget):
+class IMilestone(IHasBugs, IStructuralSubscriptionTarget,
+                 IHasOfficialBugTags):
     """A milestone, or a targeting point for bugs and other
     release-management items that need coordination.
     """
 
=== modified file 'lib/lp/registry/interfaces/person.py'
--- lib/lp/registry/interfaces/person.py	2010-02-08 14:37:50 +0000
+++ lib/lp/registry/interfaces/person.py	2010-02-12 10:32:22 +0000
@@ -97,6 +97,7 @@
 from canonical.launchpad.webapp.interfaces import NameLookupFailed
 from canonical.launchpad.webapp.authorization import check_permission
 
+from lp.bugs.interfaces.bugtarget import IHasBugs
 
 PRIVATE_TEAM_PREFIX = 'private-'
 
@@ -478,7 +479,7 @@
 class IPersonPublic(IHasBranches, IHasSpecifications, IHasMentoringOffers,
                     IHasMergeProposals, IHasLogo, IHasMugshot, IHasIcon,
                     IHasLocation, IHasRequestedReviews, IObjectWithLocation,
-                    IPrivacy):
+                    IPrivacy, IHasBugs):
     """Public attributes for a Person."""
 
     id = Int(title=_('ID'), required=True, readonly=True)
@@ -1017,18 +1018,6 @@
         used between TeamMembership and Person objects.
         """
 
-    def searchTasks(search_params, *args):
-        """Search IBugTasks with the given search parameters.
-
-        :search_params: a BugTaskSearchParams object
-        :args: any number of BugTaskSearchParams objects
-
-        If more than one BugTaskSearchParams is given, return the union of
-        IBugTasks which match any of them.
-
-        Return an iterable of matching results.
-        """
-
     def getLatestMaintainedPackages():
         """Return `SourcePackageRelease`s maintained by this person.
 
 
=== modified file 'lib/lp/registry/interfaces/product.py'
--- lib/lp/registry/interfaces/product.py	2010-01-20 13:58:45 +0000
+++ lib/lp/registry/interfaces/product.py	2010-02-12 10:32:22 +0000
@@ -724,13 +724,6 @@
 IProject['products'].value_type = Reference(IProduct)
 IProductRelease['product'].schema = IProduct
 
-# Patch the official_bug_tags field to make sure that it's
-# writable from the API, and not readonly like its definition
-# in IHasBugs.
-writable_obt_field = copy_field(IProduct['official_bug_tags'])
-writable_obt_field.readonly = False
-IProduct._v_attrs['official_bug_tags'] = writable_obt_field
-
 
 class IProductSet(Interface):
     export_as_webservice_collection(IProduct)
 
=== modified file 'lib/lp/registry/interfaces/productseries.py'
--- lib/lp/registry/interfaces/productseries.py	2009-12-13 11:55:40 +0000
+++ lib/lp/registry/interfaces/productseries.py	2010-02-12 10:32:22 +0000
@@ -24,7 +24,7 @@
 from lp.registry.interfaces.structuralsubscription import (
     IStructuralSubscriptionTarget)
 from lp.code.interfaces.branch import IBranch
-from lp.bugs.interfaces.bugtarget import IBugTarget
+from lp.bugs.interfaces.bugtarget import IBugTarget, IHasOfficialBugTags
 from lp.registry.interfaces.series import SeriesStatus
 from canonical.launchpad.interfaces.launchpad import (
     IHasAppointedDriver, IHasDrivers)
@@ -93,7 +93,8 @@
 
 
 class IProductSeriesPublic(IHasAppointedDriver, IHasDrivers, IHasOwner,
-                           IBugTarget, ISpecificationGoal, IHasMilestones):
+                           IBugTarget, ISpecificationGoal, IHasMilestones,
+                           IHasOfficialBugTags):
     """Public IProductSeries properties."""
     # XXX Mark Shuttleworth 2004-10-14: Would like to get rid of id in
     # interfaces, as soon as SQLobject allows using the object directly
 
=== modified file 'lib/lp/registry/interfaces/project.py'
--- lib/lp/registry/interfaces/project.py	2009-12-05 18:37:28 +0000
+++ lib/lp/registry/interfaces/project.py	2010-02-12 10:32:22 +0000
@@ -24,7 +24,7 @@
 from lp.code.interfaces.branchvisibilitypolicy import (
     IHasBranchVisibilityPolicy)
 from lp.code.interfaces.hasbranches import IHasBranches, IHasMergeProposals
-from lp.bugs.interfaces.bugtarget import IHasBugs
+from lp.bugs.interfaces.bugtarget import IHasBugs, IHasOfficialBugTags
 from lp.registry.interfaces.karma import IKarmaContext
 from canonical.launchpad.interfaces.launchpad import (
     IHasAppointedDriver, IHasDrivers, IHasIcon, IHasLogo, IHasMugshot)
@@ -64,7 +64,8 @@
     IHasDrivers, IHasBranchVisibilityPolicy, IHasIcon, IHasLogo,
     IHasMentoringOffers, IHasMergeProposals, IHasMilestones, IHasMugshot,
     IHasOwner, IHasSpecifications, IHasSprints, IHasTranslationGroup,
-    IMakesAnnouncements, IKarmaContext, IPillar, IRootContext):
+    IMakesAnnouncements, IKarmaContext, IPillar, IRootContext,
+    IHasOfficialBugTags):
     """Public IProject properties."""
 
     id = Int(title=_('ID'), readonly=True)
 
=== modified file 'lib/lp/registry/interfaces/sourcepackage.py'
--- lib/lp/registry/interfaces/sourcepackage.py	2010-02-04 21:18:32 +0000
+++ lib/lp/registry/interfaces/sourcepackage.py	2010-02-12 10:32:22 +0000
@@ -21,7 +21,7 @@
 from lazr.enum import DBEnumeratedType, DBItem
 
 from canonical.launchpad import _
-from lp.bugs.interfaces.bugtarget import IBugTarget
+from lp.bugs.interfaces.bugtarget import IBugTarget, IHasOfficialBugTags
 from lp.code.interfaces.hasbranches import IHasBranches, IHasMergeProposals
 from lp.soyuz.interfaces.component import IComponent
 from lazr.restful.fields import Reference, ReferenceChoice
@@ -31,7 +31,8 @@
     operation_returns_entry, REQUEST_USER)
 
 
-class ISourcePackage(IBugTarget, IHasBranches, IHasMergeProposals):
+class ISourcePackage(IBugTarget, IHasBranches, IHasMergeProposals,
+                     IHasOfficialBugTags):
     """A SourcePackage. See the MagicSourcePackage specification. This
     interface preserves as much as possible of the old SourcePackage
     interface from the SourcePackage table, with the new table-less
 
=== modified file 'lib/lp/registry/model/person.py'
--- lib/lp/registry/model/person.py	2010-02-10 23:14:56 +0000
+++ lib/lp/registry/model/person.py	2010-02-12 10:32:22 +0000
@@ -84,7 +84,7 @@
 from lp.code.model.hasbranches import (
     HasBranchesMixin, HasMergeProposalsMixin, HasRequestedReviewsMixin)
 from lp.bugs.interfaces.bugtask import (
-    BugTaskSearchParams, IBugTaskSet)
+    BugTaskSearchParams, IBugTaskSet, IllegalRelatedBugTasksParams)
 from lp.bugs.interfaces.bugtarget import IBugTarget
 from lp.registry.interfaces.codeofconduct import (
     ISignedCodeOfConductSet)
@@ -128,7 +128,8 @@
 
 from lp.soyuz.model.archive import Archive
 from lp.registry.model.codeofconduct import SignedCodeOfConduct
-from lp.bugs.model.bugtask import BugTask
+from lp.bugs.model.bugtask import (
+    BugTask, get_related_bugtasks_search_params)
 from canonical.launchpad.database.emailaddress import (
     EmailAddress, HasOwnerMixin)
 from lp.registry.model.karma import KarmaCache, KarmaTotalCache
@@ -838,6 +839,21 @@
 
     def searchTasks(self, search_params, *args, **kwargs):
         """See `IHasBugs`."""
+        if search_params is None and len(args) == 0:
+            # this method is called via webapi directly
+            # calling this method on a Person object directly via the
+            # webservice API means searching for user related tasks
+            user = kwargs.pop('user')
+            try:
+                search_params = get_related_bugtasks_search_params(
+                    user, self, **kwargs)
+            except IllegalRelatedBugTasksParams, e:
+                # dirty hack, marking an exception with a HTTP error
+                # only works if the exception is raised in the exported
+                # method, see docstring of
+                # `lazr.restful.declarations.webservice_error()`
+                raise e
+            return getUtility(IBugTaskSet).search(*search_params)
         if len(kwargs) > 0:
             # if keyword arguments are supplied, use the deault
             # implementation in HasBugsBase.
 
=== modified file 'lib/lp/registry/tests/test_person.py'
--- lib/lp/registry/tests/test_person.py	2009-12-08 17:53:37 +0000
+++ lib/lp/registry/tests/test_person.py	2010-02-12 10:32:22 +0000
@@ -29,6 +29,8 @@
 from lp.registry.model.structuralsubscription import (
     StructuralSubscription)
 from lp.registry.model.person import Person
+from lp.bugs.model.bugtask import get_related_bugtasks_search_params
+from lp.bugs.interfaces.bugtask import IllegalRelatedBugTasksParams
 from lp.answers.model.answercontact import AnswerContact
 from lp.blueprints.model.specification import Specification
 from lp.testing import TestCaseWithFactory
@@ -495,5 +497,105 @@
             name='/john')
 
 
+class TestPersonRelatedBugTaskSearch(TestCaseWithFactory):
+
+    layer = LaunchpadFunctionalLayer
+
+    def setUp(self):
+        super(TestPersonRelatedBugTaskSearch, self).setUp()
+        self.user = self.factory.makePerson(displayname="User")
+        self.context = self.factory.makePerson(displayname="Context")
+
+    def checkUserFields(
+        self, params, assignee=None, bug_subscriber=None,
+        owner=None, bug_commenter=None, bug_reporter=None):
+        self.failUnlessEqual(assignee, params.assignee)
+        # fromSearchForm() takes a bug_subscriber parameter, but saves
+        # it as subscriber on the parameter object.
+        self.failUnlessEqual(bug_subscriber, params.subscriber)
+        self.failUnlessEqual(owner, params.owner)
+        self.failUnlessEqual(bug_commenter, params.bug_commenter)
+        self.failUnlessEqual(bug_reporter, params.bug_reporter)
+
+    def test_get_related_bugtasks_search_params(self):
+        # With no specified options, get_related_bugtasks_search_params()
+        # returns 4 BugTaskSearchParams objects, each with a different
+        # user field set.
+        search_params = get_related_bugtasks_search_params(self.user, self.context)
+        self.assertEqual(len(search_params), 4)
+        self.checkUserFields(
+            search_params[0], assignee=self.context)
+        self.checkUserFields(
+            search_params[1], bug_subscriber=self.context)
+        self.checkUserFields(
+            search_params[2], owner=self.context, bug_reporter=self.context)
+        self.checkUserFields(
+            search_params[3], bug_commenter=self.context)
+
+    def test_get_related_bugtasks_search_params_with_assignee(self):
+        # With assignee specified, get_related_bugtasks_search_params() returns
+        # 3 BugTaskSearchParams objects.
+        search_params = get_related_bugtasks_search_params(
+            self.user, self.context, assignee=self.user)
+        self.assertEqual(len(search_params), 3)
+        self.checkUserFields(
+            search_params[0], assignee=self.user, bug_subscriber=self.context)
+        self.checkUserFields(
+            search_params[1], assignee=self.user, owner=self.context,
+            bug_reporter=self.context)
+        self.checkUserFields(
+            search_params[2], assignee=self.user, bug_commenter=self.context)
+
+    def test_get_related_bugtasks_search_params_with_owner(self):
+        # With owner specified, get_related_bugtasks_search_params() returns
+        # 3 BugTaskSearchParams objects.
+        search_params = get_related_bugtasks_search_params(
+            self.user, self.context, owner=self.user)
+        self.assertEqual(len(search_params), 3)
+        self.checkUserFields(
+            search_params[0], owner=self.user, assignee=self.context)
+        self.checkUserFields(
+            search_params[1], owner=self.user, bug_subscriber=self.context)
+        self.checkUserFields(
+            search_params[2], owner=self.user, bug_commenter=self.context)
+
+    def test_get_related_bugtasks_search_params_with_bug_reporter(self):
+        # With bug reporter specified, get_related_bugtasks_search_params()
+        # returns 4 BugTaskSearchParams objects, but the bug reporter
+        # is overwritten in one instance.
+        search_params = get_related_bugtasks_search_params(
+            self.user, self.context, bug_reporter=self.user)
+        self.assertEqual(len(search_params), 4)
+        self.checkUserFields(
+            search_params[0], bug_reporter=self.user,
+            assignee=self.context)
+        self.checkUserFields(
+            search_params[1], bug_reporter=self.user,
+            bug_subscriber=self.context)
+        # When a BugTaskSearchParams is prepared with the owner filled
+        # in, the bug reporter is overwritten to match.
+        self.checkUserFields(
+            search_params[2], bug_reporter=self.context,
+            owner=self.context)
+        self.checkUserFields(
+            search_params[3], bug_reporter=self.user,
+            bug_commenter=self.context)
+
+    def test_get_related_bugtasks_search_params_illegal(self):
+        self.assertRaises(
+            IllegalRelatedBugTasksParams,
+            get_related_bugtasks_search_params, self.user, self.context,
+            assignee=self.user, owner=self.user, bug_commenter=self.user,
+            bug_subscriber=self.user)
+
+    def test_get_related_bugtasks_search_params_illegal_context(self):
+        # in case the `context` argument is not  of type IPerson an
+        # AssertionError is raised
+        self.assertRaises(
+            AssertionError,
+            get_related_bugtasks_search_params, self.user, "Username",
+            assignee=self.user)
+
+
 def test_suite():
     return unittest.TestLoader().loadTestsFromName(__name__)