Merge lp:~ted/ubuntu-app-launch/zg-no-error into lp:ubuntu-app-launch/15.10

Proposed by Ted Gould
Status: Merged
Approved by: Charles Kerr
Approved revision: 196
Merged at revision: 199
Proposed branch: lp:~ted/ubuntu-app-launch/zg-no-error
Merge into: lp:ubuntu-app-launch/15.10
Diff against target: 11 lines (+1/-1)
1 file modified
zg-report-app.c (+1/-1)
To merge this branch: bzr merge lp:~ted/ubuntu-app-launch/zg-no-error
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+260297@code.launchpad.net

Commit message

Don't error on ZG failure

Description of the change

We're overreacting here. It seems that ZG will detect this error and clean up the dirty DB when it happens, so it's not a big deal. We should still report it, but it's not worth an entry in errors.u.c to track it.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'zg-report-app.c'
--- zg-report-app.c 2014-09-10 14:54:01 +0000
+++ zg-report-app.c 2015-05-27 13:53:48 +0000
@@ -39,7 +39,7 @@
39 result = zeitgeist_log_insert_event_finish(ZEITGEIST_LOG(obj), res, &error);39 result = zeitgeist_log_insert_event_finish(ZEITGEIST_LOG(obj), res, &error);
4040
41 if (error != NULL) {41 if (error != NULL) {
42 g_error("Unable to submit Zeitgeist Event: %s", error->message);42 g_warning("Unable to submit Zeitgeist Event: %s", error->message);
43 g_error_free(error);43 g_error_free(error);
44 }44 }
4545

Subscribers

People subscribed via source and target branches