Merge lp:~ted/indicator-sound/test-failures into lp:indicator-sound/14.04

[Ted Gould]

Don't unref the objects in the test

Uhg, not sure why we don't get ref's in these functions, but we don't. Err, vala.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:436
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/123/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-trusty-amd64-ci/63/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-trusty-armhf-ci/62
        deb: http://jenkins.qa.ubuntu.com/job/indicator-sound-trusty-armhf-ci/62/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/123/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:436
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/125/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-trusty-amd64-ci/65
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-trusty-armhf-ci/64
        deb: http://jenkins.qa.ubuntu.com/job/indicator-sound-trusty-armhf-ci/64/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/125/rebuild

review: Approve (continuous-integration)

[Charles Kerr (charlesk)]

That must've been a fun one to track down.

The GIcon* returned by g_app_info_get_icon (GAppInfo *appinfo) is [transfer none], so GLib.AppInfo.get_icon()'s return value is unowned.

review: Approve

=== modified file 'tests/media-player-user.cc'
--- tests/media-player-user.cc	2014-03-04 21:24:10 +0000
+++ tests/media-player-user.cc	2014-03-25 15:58:12 +0000
@@ -163,7 +163,7 @@
 	GIcon * out_icon = media_player_get_icon(MEDIA_PLAYER(player));
 	EXPECT_NE(nullptr, out_icon);
 	EXPECT_TRUE(g_icon_equal(in_icon, out_icon));
-	g_clear_object(&out_icon);
+	// NOTE: No reference in 'out_icon' returned
 
 	MediaPlayerTrack * track = media_player_get_current_track(MEDIA_PLAYER(player));
 	EXPECT_NE(nullptr, track);
@@ -171,7 +171,7 @@
 	EXPECT_STREQ("Bansky", media_player_track_get_artist(track));
 	EXPECT_STREQ("Vinyl is dead", media_player_track_get_album(track));
 	EXPECT_STREQ("http://art.url", media_player_track_get_art_url(track));
-	g_clear_object(&track);
+	// NOTE: No reference in 'track' returned
 
 	g_clear_object(&in_icon);
 	g_clear_object(&player);