Merge lp:~ted/indicator-messages/telepathy-offline into lp:indicator-messages/0.3

Proposed by Ted Gould
Status: Merged
Approved by: Charles Kerr
Approved revision: 268
Merged at revision: 268
Proposed branch: lp:~ted/indicator-messages/telepathy-offline
Merge into: lp:indicator-messages/0.3
Diff against target: 30 lines (+3/-3)
1 file modified
src/status-provider-mc5.c (+3/-3)
To merge this branch: bzr merge lp:~ted/indicator-messages/telepathy-offline
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
Review via email: mp+101140@code.launchpad.net

Description of the change

Make it so that when your session lauches you're offline instead of disconnected. That way the items are visible and you can go online. Which seems like a feature :-)

To post a comment you must log in.
Revision history for this message
Charles Kerr (charlesk) wrote :

I'm surprised there's not a ticket associated with this, it seems like a pretty big catch...

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/status-provider-mc5.c'
--- src/status-provider-mc5.c 2011-07-02 12:15:22 +0000
+++ src/status-provider-mc5.c 2012-04-06 18:20:23 +0000
@@ -137,7 +137,7 @@
137{137{
138 StatusProviderMC5Private * priv = STATUS_PROVIDER_MC5_GET_PRIVATE(self);138 StatusProviderMC5Private * priv = STATUS_PROVIDER_MC5_GET_PRIVATE(self);
139139
140 priv->status = STATUS_PROVIDER_STATUS_DISCONNECTED;140 priv->status = STATUS_PROVIDER_STATUS_OFFLINE;
141 priv->manager = NULL;141 priv->manager = NULL;
142142
143 DBusGConnection * bus = dbus_g_bus_get(DBUS_BUS_SESSION, NULL);143 DBusGConnection * bus = dbus_g_bus_get(DBUS_BUS_SESSION, NULL);
@@ -219,7 +219,7 @@
219 priv->manager = NULL;219 priv->manager = NULL;
220 }220 }
221221
222 priv->status = STATUS_PROVIDER_STATUS_DISCONNECTED;222 priv->status = STATUS_PROVIDER_STATUS_OFFLINE;
223 g_signal_emit(G_OBJECT(self), STATUS_PROVIDER_SIGNAL_STATUS_CHANGED_ID, 0, priv->status, TRUE);223 g_signal_emit(G_OBJECT(self), STATUS_PROVIDER_SIGNAL_STATUS_CHANGED_ID, 0, priv->status, TRUE);
224 }224 }
225225
@@ -282,7 +282,7 @@
282 StatusProviderMC5Private * priv = STATUS_PROVIDER_MC5_GET_PRIVATE(sp);282 StatusProviderMC5Private * priv = STATUS_PROVIDER_MC5_GET_PRIVATE(sp);
283283
284 if (priv->manager == NULL) {284 if (priv->manager == NULL) {
285 return STATUS_PROVIDER_STATUS_DISCONNECTED;285 return STATUS_PROVIDER_STATUS_OFFLINE;
286 }286 }
287287
288 return priv->status;288 return priv->status;

Subscribers

People subscribed via source and target branches