Merge ~szeestraten/charm-nagios:bug/1864968 into ~nagios-charmers/charm-nagios:master
Proposed by
Sandor Zeestraten
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 73961bbffd6735574cc63a525a96ad26c58d0e38 | ||||
Proposed branch: | ~szeestraten/charm-nagios:bug/1864968 | ||||
Merge into: | ~nagios-charmers/charm-nagios:master | ||||
Diff against target: |
112 lines (+75/-7) 3 files modified
config.yaml (+62/-0) hooks/templates/contacts-cfg.tmpl (+6/-6) hooks/upgrade-charm (+7/-1) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alvaro Uria (community) | Approve | ||
Xav Paice (community) | Needs Fixing | ||
Review via email: mp+379943@code.launchpad.net |
To post a comment you must log in.
Many thanks for this patch.
I've made a few comments regarding the config options in config.yaml, around documentation. The change itself seems good, and has tested OK via a manual deployment test.