Merge ~sylvain-pineau/plainbox-provider-checkbox:fix-1701226 into plainbox-provider-checkbox:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: a70c97fd5bf7cab7826253c15f4d5b4f1f88e079
Merged at revision: b815c58410017a57c0fee9d6f8102b1a444393d7
Proposed branch: ~sylvain-pineau/plainbox-provider-checkbox:fix-1701226
Merge into: plainbox-provider-checkbox:master
Diff against target: 43 lines (+2/-14)
2 files modified
jobs/input.txt.in (+1/-13)
jobs/miscellanea.txt.in (+1/-1)
Reviewer Review Type Date Requested Status
Maciej Kisielewski Approve
Review via email: mp+326991@code.launchpad.net

Description of the change

Automation of the accelerometer detection

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

LGTM! +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/jobs/input.txt.in b/jobs/input.txt.in
index b1cbe61..0bf880d 100644
--- a/jobs/input.txt.in
+++ b/jobs/input.txt.in
@@ -41,24 +41,12 @@ _description:
41 VERIFICATION:41 VERIFICATION:
42 Is your keyboard working properly?42 Is your keyboard working properly?
4343
44plugin: manual
45category_id: com.canonical.plainbox::input
46id: input/accelerometer_verify
47estimated_duration: 30.0
48_description:
49 PURPOSE:
50 Manual detection of accelerometer.
51 STEPS:
52 1. Look at the specifications for your system.
53 VERIFICATION:
54 Is this system supposed to have an accelerometer?
55
56plugin: user-interact44plugin: user-interact
57category_id: com.canonical.plainbox::input45category_id: com.canonical.plainbox::input
58id: input/accelerometer46id: input/accelerometer
59estimated_duration: 60.047estimated_duration: 60.0
60user: root48user: root
61depends: input/accelerometer_verify49requires: device.category == 'ACCELEROMETER'
62command: accelerometer_test -m50command: accelerometer_test -m
63_description:51_description:
64 PURPOSE:52 PURPOSE:
diff --git a/jobs/miscellanea.txt.in b/jobs/miscellanea.txt.in
index fe26ae1..dc79a32 100644
--- a/jobs/miscellanea.txt.in
+++ b/jobs/miscellanea.txt.in
@@ -325,7 +325,7 @@ plugin: user-interact-verify
325category_id: com.canonical.plainbox::miscellanea325category_id: com.canonical.plainbox::miscellanea
326estimated_duration: 5.0326estimated_duration: 5.0
327id: miscellanea/device_check327id: miscellanea/device_check
328command: udev_resource -l VIDEO NETWORK WIRELESS DISK | tee >([[ $DISPLAY ]] && zenity --text-info --title="Device report")328command: udev_resource -l VIDEO NETWORK WIRELESS DISK ACCELEROMETER | tee >([[ $DISPLAY ]] && zenity --text-info --title="Device report")
329_summary: Device Check329_summary: Device Check
330_purpose:330_purpose:
331 Device check331 Device check

Subscribers

People subscribed via source and target branches