Merge lp:~stub/launchpad/oops into lp:launchpad
Proposed by
Stuart Bishop
Status: | Merged |
---|---|
Approved by: | Stuart Bishop |
Approved revision: | 10004 |
Merged at revision: | 14299 |
Proposed branch: | lp:~stub/launchpad/oops |
Merge into: | lp:launchpad |
Prerequisite: | lp:~stub/launchpad/trivial |
Diff against target: |
59 lines (+31/-0) 2 files modified
lib/canonical/launchpad/webapp/errorlog.py (+10/-0) lib/canonical/launchpad/webapp/tests/test_errorlog.py (+21/-0) |
To merge this branch: | bzr merge lp:~stub/launchpad/oops |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Raphaël Badin (community) | Approve | ||
Review via email: mp+82119@code.launchpad.net |
Commit message
[r=rvb][no-qa] Attach a link to the previous OOPS generated in the request, if any.
Description of the change
Attach a link to the previous OOPS generated in the request, if any.
To post a comment you must log in.
Looks good.
One remark:
12 + if last_oopsid:
Not sure it's worth it but maybe it would be more safe/explicit to write: "if last_oopsid is not None:".