Merge lp:~stewart/percona-server/5.1-deprecate-innodb-fast-checksum into lp:percona-server/5.1

[Stewart Smith]

In PS5.6, we'll be removing innodb_fast_checksum, as the improved InnoDB implementation should be good enough/better. This MP adds a warning for that so that users are (less) surprised.

[George Ormond Lorch III (gl-az)]

review: Approve (g2)

[Laurynas Biveinis (laurynas-biveinis)]

fprintf should be indented as InnoDB, not MySQL code (8 space tab instead of 2 spaces).
Also in the fprintf s/WARNING/Warning, the latter is much more common and the MTR error/warning check will not miss it.

OK with these two changes.

review: Approve

=== modified file 'Percona-Server/storage/innodb_plugin/handler/ha_innodb.cc'
--- Percona-Server/storage/innodb_plugin/handler/ha_innodb.cc	2012-09-14 12:19:29 +0000
+++ Percona-Server/storage/innodb_plugin/handler/ha_innodb.cc	2012-10-26 04:39:21 +0000
@@ -2540,6 +2540,14 @@
 	srv_use_checksums = (ibool) innobase_use_checksums;
 	srv_fast_checksum = (ibool) innobase_fast_checksum;
 
+	if (innobase_fast_checksum) {
+		fprintf(stderr,
+			"InnoDB: Warning: innodb_fast_checksum is DEPRECATED "
+			"and *WILL* be removed in Percona Server 5.6. Please "
+			"consult the Percona Server 5.6 documentation for "
+			"help in upgrading.\n");
+	}
+
 	srv_blocking_lru_restore = (ibool) innobase_blocking_lru_restore;
 
 #ifdef HAVE_LARGE_PAGES
@@ -11584,6 +11592,8 @@
 
 static MYSQL_SYSVAR_BOOL(fast_checksum, innobase_fast_checksum,
   PLUGIN_VAR_NOCMDARG | PLUGIN_VAR_READONLY,
+  "DEPRECATED. #### WARNING #### : This feature is DEPRECATED and WILL "
+  "be removed in Percona Server 5.6. "
   "Change the algorithm of checksum for the whole of datapage to 4-bytes word based. "
   "The original checksum is checked after the new one. It may be slow for reading page"
   " which has orginal checksum. Overwrite the page or recreate the InnoDB database, "