Merge lp:~steve-salevan/gearmand/fix_redis_queue into lp:gearmand

[Steve Salevan]

Hey there!

This patch enables operation of Redis as a Gearman queueing backend via fixing a minor bug in the logic used to delete Redis keys; it appears that the logic in the current code may have been confused with a call to the logging subsystem. Redis-backed queue persistence has worked reliably for us over the past month or so with this fix, so I wanted to submit it to the upstream for review.

Let me know if I can supply any further information; otherwise, thanks much for the review!
-Steve Salevan
<email address hidden>

[Brian Aker (brianaker)]

Thanks!

[Brian Aker (brianaker)]

BTW looking through the code I found a couple of issues (one is that it couldn't talk to servers that weren't localhost... which I fixed).

The other issue is that priority and when are not currently stored. I believe that with redis you can store complex objects right?

If so it would be good to fix that.

=== modified file 'libgearman-server/plugins/queue/redis/queue.cc'
--- libgearman-server/plugins/queue/redis/queue.cc	2013-05-12 01:03:50 +0000
+++ libgearman-server/plugins/queue/redis/queue.cc	2013-06-11 19:03:29 +0000
@@ -231,7 +231,7 @@
   std::vector<char> key;
   build_key(key, unique, unique_size, function_name, function_name_size);
 
-  redisReply *reply= (redisReply*)redisCommand(queue->redis(), "DELETE %.*s", key.size(), &key[0]);
+  redisReply *reply= (redisReply*)redisCommand(queue->redis(), "DEL %b", &key[0], key.size());
   if (reply == NULL)
   {
     return GEARMAND_QUEUE_ERROR;