Merge lp:~smoser/maas/drop-ttyS0-kernel-opt into lp:~maas-committers/maas/trunk
Status: | Merged |
---|---|
Approved by: | Scott Moser |
Approved revision: | no longer in the source branch. |
Merged at revision: | 1241 |
Proposed branch: | lp:~smoser/maas/drop-ttyS0-kernel-opt |
Merge into: | lp:~maas-committers/maas/trunk |
Diff against target: |
27 lines (+3/-3) 2 files modified
src/provisioningserver/kernel_opts.py (+2/-2) src/provisioningserver/tests/test_kernel_opts.py (+1/-1) |
To merge this branch: | bzr merge lp:~smoser/maas/drop-ttyS0-kernel-opt |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andres Rodriguez (community) | Approve | ||
Review via email: mp+128747@code.launchpad.net |
Commit message
on intel, do not send 'console=ttyS0' (or console=tty1)
as described in LP: #1061977, passing console=ttyS0 to a system that does not
have serial hardware can result in writes to /dev/console failing. During
enlistment and commissioning, that can also cause those stages to fail as
the enlistment/
to /dev/console by upstart.
This change gives evidence to the requirement for LP: #1044503, as the
only way a user can now add 'console=ttyS0' is by editing files in
/usr/share/
package upgrade.
Description of the change
on intel, do not send 'console=ttyS0' (or console=tty1)
as described in LP: #1061977, passing console=ttyS0 to a system that does not
have serial hardware can result in writes to /dev/console failing. During
enlistment and commissioning, that can also cause those stages to fail as
the enlistment/
to /dev/console by upstart.
This change gives evidence to the requirement for LP: #1044503, as the
only way a user can now add 'console=ttyS0' is by editing files in
/usr/share/
package upgrade.
looks good to me