Merge lp:~sil2100/libsignon-glib/fix_linking_again into lp:libsignon-glib

Proposed by Łukasz Zemczak
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: 148
Merged at revision: 148
Proposed branch: lp:~sil2100/libsignon-glib/fix_linking_again
Merge into: lp:libsignon-glib
Diff against target: 13 lines (+2/-1)
1 file modified
tests/Makefile.am (+2/-1)
To merge this branch: bzr merge lp:~sil2100/libsignon-glib/fix_linking_again
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+171027@code.launchpad.net

Commit message

Previous fix was not enough, we need to add manually pthread as it's not linked, because the toolchain, quoting, 'only links with needed libraries'

Description of the change

Previous fix was not enough, we need to add manually pthread as it's not linked, because the toolchain, quoting, 'only links with needed libraries'.

The last fix did not work properly. I had a misunderstanding with the configure.ac, and in fact that change was not fixing anything, but because of a typo I made in configure it simply disabled the tests. This typo did not get 'into' trunk luckily.

This change, on the other hand, works - it's not beautiful, but unblocks trunk at least.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Thanks! and building fine :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/Makefile.am'
--- tests/Makefile.am 2013-06-21 14:38:02 +0000
+++ tests/Makefile.am 2013-06-24 07:49:24 +0000
@@ -10,7 +10,8 @@
10 $(CHECK_FLAGS)10 $(CHECK_FLAGS)
11signon_glib_testsuite_LDADD = \11signon_glib_testsuite_LDADD = \
12 $(top_builddir)/libsignon-glib/libsignon-glib.la \12 $(top_builddir)/libsignon-glib/libsignon-glib.la \
13 $(CHECK_LIBS) \
13 $(DEPS_LIBS) \14 $(DEPS_LIBS) \
14 $(CHECK_LIBS) 15 -lpthread
1516
16TESTS = signon-glib-test.sh17TESTS = signon-glib-test.sh

Subscribers

People subscribed via source and target branches

to all changes: