Merge lp:~shockone89/audience/universal-shortcuts into lp:~audience-members/audience/trunk

Proposed by Volodymyr Shatsky
Status: Rejected
Rejected by: Zisu Andrei
Proposed branch: lp:~shockone89/audience/universal-shortcuts
Merge into: lp:~audience-members/audience/trunk
Diff against target: 16 lines (+5/-1)
1 file modified
Audience/Audience.vala (+5/-1)
To merge this branch: bzr merge lp:~shockone89/audience/universal-shortcuts
Reviewer Review Type Date Requested Status
Zisu Andrei (community) Disapprove
Artem Anufrij (community) functionality Needs Fixing
Volodymyr Shatsky Pending
Review via email: mp+157533@code.launchpad.net

Description of the change

Finally shortcuts work with Russian layout.

To post a comment you must log in.
Revision history for this message
Volodymyr Shatsky (shockone89) wrote :

Cody, I saw your question about this keyboard layouts thing on some mailing list the other day. Maybe this technique will be useful for your Pantheon Terminal.

Revision history for this message
Artem Anufrij (artem-anufrij) wrote :

I can't confirm this solution.

On my system (russian layout) CTRL+Q (as example) doesn't work.

review: Needs Fixing (functionality)
Revision history for this message
Zisu Andrei (matzipan) wrote :

Rejecting since bug #1235489 has been marked as fixed.

review: Disapprove

Unmerged revisions

251. By Volodymyr Shatsky

Shortcuts work with all keyboard layouts

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Audience/Audience.vala'
--- Audience/Audience.vala 2013-04-02 16:46:22 +0000
+++ Audience/Audience.vala 2013-04-07 04:41:18 +0000
@@ -218,7 +218,11 @@
218 218
219 //shortcuts219 //shortcuts
220 this.mainwindow.key_press_event.connect ( (e) => {220 this.mainwindow.key_press_event.connect ( (e) => {
221 switch (e.keyval) {221 //Covert the key to the English layout
222 Gdk.KeymapKey keymap_key = Gdk.KeymapKey () {keycode = e.hardware_keycode};
223 uint keyval = Gdk.Keymap.get_default ().lookup_key (keymap_key);
224
225 switch (keyval) {
222 case Gdk.Key.p:226 case Gdk.Key.p:
223 case Gdk.Key.space:227 case Gdk.Key.space:
224 video_player.playing = !video_player.playing;228 video_player.playing = !video_player.playing;

Subscribers

People subscribed via source and target branches