Merge ~sergiodj/ubuntu/+source/sssd:bug1900642-condpathexists-hirsute into ubuntu/+source/sssd:ubuntu/devel
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Sergio Durigan Junior | ||||
Approved revision: | 75fe00ec14da927c4928226d843f9df1a5e1729a | ||||
Merged at revision: | 75fe00ec14da927c4928226d843f9df1a5e1729a | ||||
Proposed branch: | ~sergiodj/ubuntu/+source/sssd:bug1900642-condpathexists-hirsute | ||||
Merge into: | ubuntu/+source/sssd:ubuntu/devel | ||||
Diff against target: |
160 lines (+96/-37) 4 files modified
debian/changelog (+9/-0) debian/patches/0003-Only-start-sssd.service-if-there-s-a-configuration-f.patch (+86/-0) debian/patches/series (+1/-1) dev/null (+0/-36) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Bryce Harrington (community) | Approve | ||
Canonical Server | Pending | ||
Review via email: mp+396206@code.launchpad.net |
Description of the change
This is a MP to address bug 1900642 on hirsute. It includes a patch that comes directly from upstream, which accepted my solution (after some tweaking). This MP basically replaces an old approach to solve the problem by a new one, which is more complete.
In a nutshell, what the new patch does is to include some conditions in the sssd.service file that are responsible for checking whether the user as (a) a file named /etc/sssd/
It's important to mention that these conditions will only be added to the service file if sssd has been compiled without --enable-
Looks good. I reviewed bug report (and SRU template), and past work on this bug. I did not test out the behavior but assume you've tested it thoroughly already. The approach looks correct and I verified the systemd logic against documentation.