Merge ~sergiodj/lp-ftbfs-report:master into ~ubuntu-test-rebuild/lp-ftbfs-report:master

Proposed by Sergio Durigan Junior
Status: Merged
Merged at revision: 212464afefc2664dac8b774320dabbf51445667b
Proposed branch: ~sergiodj/lp-ftbfs-report:master
Merge into: ~ubuntu-test-rebuild/lp-ftbfs-report:master
Diff against target: 34 lines (+4/-4)
1 file modified
source/build_status.html (+4/-4)
Reviewer Review Type Date Requested Status
Graham Inggs Pending
Ubuntu Archive Test Rebuilds Pending
Review via email: mp+414130@code.launchpad.net

Description of the change

When the packageset and the team names are the same, the internal links for each of these will end up also being the same. Currently, because the packageset section comes first in the page, that means that the team internal link will point to it.

A simple fix is to use distinct suffixes to compose the internal link names, which help differentiate them.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/source/build_status.html b/source/build_status.html
index 994e71b..8365320 100644
--- a/source/build_status.html
+++ b/source/build_status.html
@@ -137,12 +137,12 @@
137137
138 <p>Jump to packageset:138 <p>Jump to packageset:
139 {% for (ps, lst) in packagesets.items()|sort if lst|count > 0 -%}139 {% for (ps, lst) in packagesets.items()|sort if lst|count > 0 -%}
140 <a href="#{{ ps }}">{{ ps }}</a> ({{ lst|count }})140 <a href="#{{ ps }}-pkgset">{{ ps }}</a> ({{ lst|count }})
141 {% endfor -%}141 {% endfor -%}
142 </p>142 </p>
143 <p>Jump to team:143 <p>Jump to team:
144 {% for (team, lst) in teams.items()|sort if lst|count > 0 -%}144 {% for (team, lst) in teams.items()|sort if lst|count > 0 -%}
145 <a href="#{{ team }}">{{ team }}</a> ({{ lst|count }})145 <a href="#{{ team }}-team">{{ team }}</a> ({{ lst|count }})
146 {% endfor -%}146 {% endfor -%}
147 </p>147 </p>
148148
@@ -200,13 +200,13 @@
200200
201 <h2>Packagesets</h2>201 <h2>Packagesets</h2>
202 {% for (ps, lst) in packagesets.items()|sort if lst|count > 0 -%}202 {% for (ps, lst) in packagesets.items()|sort if lst|count > 0 -%}
203 <h3 id="{{ ps }}">{{ ps }}: {{ lst|count }} packages (<a href="#top">top</a>)</h3>203 <h3 id="{{ ps }}-pkgset">{{ ps }}: {{ lst|count }} packages (<a href="#top">top</a>)</h3>
204 {{ table(lst, ps, 'Also belongs to another packageset?') }}204 {{ table(lst, ps, 'Also belongs to another packageset?') }}
205 {% endfor -%}205 {% endfor -%}
206206
207 <h2>Teams (main only)</h2>207 <h2>Teams (main only)</h2>
208 {% for (team, lst) in teams.items()|sort if lst|count > 0 -%}208 {% for (team, lst) in teams.items()|sort if lst|count > 0 -%}
209 <h3 id="{{ team }}">{{ team }}: {{ lst|count }} packages (<a href="#top">top</a>)</h3>209 <h3 id="{{ team }}-team">{{ team }}: {{ lst|count }} packages (<a href="#top">top</a>)</h3>
210 {{ table(lst, team, 'Also belongs to another team?') }}210 {{ table(lst, team, 'Also belongs to another team?') }}
211 {% endfor -%}211 {% endfor -%}
212212

Subscribers

People subscribed via source and target branches