Merge lp:~sergei.glushchenko/percona-server/56-bug1157037 into lp:percona-server/5.6

[Sergei Glushchenko]

Bug 1157037 create_duplicate_weedout_tmp_table() leaves key_part_flag uninitialized
Manual initialization of key_part_info fields has been replaced with
KEY_PART_INFO::init_from_field invocation

http://jenkins.percona.com/view/PS%205.6/job/percona-server-5.6-param/60/

[Laurynas Biveinis (laurynas-biveinis)]

This fix was consumed by https://code.launchpad.net/~laurynas-biveinis/percona-server/5.6-merge-1/+merge/163391

review: Disapprove

Unmerged revisions

323. By Sergei Glushchenko on 2013-03-21

Bug 1157037 create_duplicate_weedout_tmp_table() leaves key_part_flag uninitialized
Manual initialization of key_part_info fields has been replaced with
KEY_PART_INFO::init_from_field invocation.

=== modified file 'Percona-Server/sql/sql_tmp_table.cc'
--- Percona-Server/sql/sql_tmp_table.cc	2013-02-12 07:47:19 +0000
+++ Percona-Server/sql/sql_tmp_table.cc	2013-03-22 04:56:25 +0000
@@ -1395,12 +1395,7 @@
     keyinfo->algorithm= HA_KEY_ALG_UNDEF;
     keyinfo->name= (char*) "weedout_key";
     {
-      key_part_info->null_bit=0;
-      key_part_info->field=  field;
-      key_part_info->offset= field->offset(table->record[0]);
-      key_part_info->length= (uint16) field->key_length();
-      key_part_info->type=   (uint8) field->key_type();
-      key_part_info->key_type = FIELDFLAG_BINARY;
+      key_part_info->init_from_field(field);
       if (!using_unique_constraint)
       {
         key_field= field->new_key_field(thd->mem_root, table, group_buff);