Merge lp:~sbte/indicator-application/fix-memory-leak into lp:indicator-application/0.5

[Sven Baars]

Free the result of g_dbus_proxy_call_finish after use

I'm not sure if this really fixes https://bugs.launchpad.net/ubuntu/+source/indicator-application/+bug/930291 , but I think this was a real leak, so I shouldn't do any harm.

[Hernando Torque (htorque)]

Unfortunately not fixing the big leak.

[Ted Gould (ted)]

Looks good. Also, for Hernando, did you try 0.4.90? I fixed a few
leaks in that one as well.

  status approved
  review approve

review: Approve

[Hernando Torque (htorque)]

Yes, see bug 930291. I now also tried it again with all the (non-unity-2d) stuff from the Unity staging PPA compiled from trunk + the three not yet merged patches from sbte → no luck. It's also not application dependent (running all combinations of: nm-applet, cpufreq, sensors, multiload).

=== modified file 'src/application-service-appstore.c'
--- src/application-service-appstore.c	2012-02-08 16:59:30 +0000
+++ src/application-service-appstore.c	2012-02-11 11:06:17 +0000
@@ -1466,6 +1466,7 @@
 	if (error == NULL) {
 		g_variant_get(result, "(b)", &approved);
 		g_debug("Approver responded: %s", approved ? "approve" : "rejected");
+		g_variant_unref(result);
 	}
 	else {
 		g_debug("Approver responded error: %s", error->message);
@@ -1654,4 +1655,3 @@
 
 	return;
 }
-