Merge lp:~savoirfairelinux-openerp/partner-contact-management/user-firstname into lp:~partner-contact-core-editors/partner-contact-management/7.0

Status: Merged
Approved by: Holger Brunn (Therp)
Approved revision: 36
Merged at revision: 36
Proposed branch: lp:~savoirfairelinux-openerp/partner-contact-management/user-firstname
Merge into: lp:~partner-contact-core-editors/partner-contact-management/7.0
Diff against target: 36 lines (+16/-3)
1 file modified
partner_firstname/res_user_view.xml (+16/-3)
To merge this branch: bzr merge lp:~savoirfairelinux-openerp/partner-contact-management/user-firstname
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) code review Approve
Jonathan Nemry (Acsone) (community) code review Approve
Yannick Vaucher @ Camptocamp code review, no tests Approve
Pedro Manuel Baeza code review Approve
Review via email: mp+210710@code.launchpad.net

Description of the change

Adapt user form to look like partner form
* Name field replaced by Firstname and Lastname

To post a comment you must log in.
36. By Sandy Carter (http://www.savoirfairelinux.com)

Adapt user form to display first name and last name like partner form

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

LGTM

review: Approve (code review)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Thanks for the contrib, LGTM

review: Approve (code review, no tests)
Revision history for this message
Jonathan Nemry (Acsone) (nemry) wrote :

LGTM

review: Approve (code review)
Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'partner_firstname/res_user_view.xml'
--- partner_firstname/res_user_view.xml 2014-01-22 15:46:07 +0000
+++ partner_firstname/res_user_view.xml 2014-03-12 23:29:57 +0000
@@ -1,16 +1,29 @@
1<?xml version="1.0" encoding="utf-8"?>1<?xml version="1.0" encoding="utf-8"?>
2<openerp>2<openerp>
3 <data>3 <data>
4
5 <!-- Replace name with first name and last name -->
4 <record id="view_users_form" model="ir.ui.view">6 <record id="view_users_form" model="ir.ui.view">
5 <field name="name">res.users.form.firstname</field>7 <field name="name">res.users.form.firstname</field>
6 <field name="model">res.users</field>8 <field name="model">res.users</field>
7 <field name="inherit_id" ref="base.view_users_form"/>9 <field name="inherit_id" ref="base.view_users_form"/>
8 <field name="arch" type="xml">10 <field name="arch" type="xml">
9 <field name="name" position="attributes">11
10 <attribute name="readonly">False</attribute>12 <label for="name" position="replace">
11 <attribute name="required">True</attribute>13 <label for="firstname" class="oe_edit_only"/>
14 </label>
15
16 <field name="name" position="replace">
17 <field name="firstname"/>
12 </field>18 </field>
19
20 <label for="login" position="before">
21 <label for="lastname" class="oe_edit_only"/>
22 <h1><field name="lastname"/></h1>
23 </label>
24
13 </field>25 </field>
14 </record>26 </record>
27
15 </data>28 </data>
16</openerp>29</openerp>