Merge lp:~santileortiz/slingshot/fix-1635776 into lp:~elementary-pantheon/slingshot/trunk

[Santiago]

Remove ancient GDK_MODIFIER hack that breaks input methods like fcitx (lp:1602472)

Fixes input methods on the search entry.

All flags that were not modifiers were being cleared from the event, in particular GDK_MODIFIER_RESERVED_25_MASK was being cleared, which caused an infinite loop when an input method was active (for instance Fcitx).

=== modified file 'src/SlingshotView.vala'
--- src/SlingshotView.vala	2016-11-21 04:43:16 +0000
+++ src/SlingshotView.vala	2017-01-06 21:08:00 +0000
@@ -343,21 +343,9 @@
             }
         }
 
-        /*
-          Overriding the default handler results in infinite loop of error messages
-          when an input method is in use (Gtk3 bug?).  Key press events are
-          captured by an Event Box and passed to this function instead.
-
-          Events not dealt with here are propagated to the search_entry by the
-          usual mechanism.
-        */
         public bool on_key_press (Gdk.EventKey event) {
             var key = Gdk.keyval_name (event.keyval).replace ("KP_", "");
 
-            event.state &= (Gdk.ModifierType.SHIFT_MASK |
-                            Gdk.ModifierType.MOD1_MASK |
-                            Gdk.ModifierType.CONTROL_MASK);
-
             if ((event.state & Gdk.ModifierType.CONTROL_MASK) != 0 &&
                 (key == "1" || key == "2")) {
                 change_view_mode (key);