Merge lp:~sajoupa/turku/turku-api-snapshot-mode-default-link-dest-lmf-lrf into lp:turku/turku-api

[Laurent Sesquès]

If using large modifying or rotating files, make snapshot-mode default to link-dest

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

[Tom Haddon (mthaddon)]

LGTM

review: Approve

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

Change successfully merged at revision 68

=== modified file 'turku_api/views.py'
--- turku_api/views.py	2020-06-21 23:57:42 +0000
+++ turku_api/views.py	2021-10-18 16:29:21 +0000
@@ -374,6 +374,16 @@
                             req_sources[s.name][k]
                         )
                     modified = True
+                if (                                                                                                                       
+                    k in ("large_rotating_files", "large_modifying_files")                                                                 
+                    and k in req_sources[s.name]                     
+                    and req_sources[s.name][k]                                                                                             
+                    and "snapshot_mode" not in req_sources[s.name]                                                                         
+                ):
+                    # The request specified large modifying or rotating files, but not snapshot mode.
+                    # Default to link-dest.
+                    setattr(s, "snapshot_mode", "link-dest")
+
             for k in ("filter", "exclude"):
                 if k not in req_sources[s.name]:
                     continue